Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

Async: every connection opens its own topology monitor connection (pool of N holds 2N connections)

Offen
  • Stimmt etwas nicht?
#1,284 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@AhmadMasry arbeitet bereits daran.

Seit 06.10.2026.

  • #1285 von @AhmadMasry — ohne Merge geschlossen
  • #1290 von @AhmadMasry — offen

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
25/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
postgresql, python, sqlalchemy
Bereich
backend, databases

Rechercherichtung

Start with aio/wrapper.py, aio/host_list_provider.py, and aio/host_monitoring_plugin.py to compare provider construction, monitor sharing, and resource release; inspect the linked pull requests first, since work is already underway. Reproduce the issue using the script in the report and check that connections to one cluster share a monitor and that it stops after the last connection releases it.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Describe the bug

With the async API (aws_advanced_python_wrapper.aio), every application connection that uses a topology-aware plugin (failover, failover_v2, read_write_splitting, custom_endpoint, ...) starts its own AsyncClusterTopologyMonitor, and each monitor opens its own dedicated monitoring connection. A pool of N connections to one cluster therefore holds 2N server connections.

The sync wrapper shares one topology monitor per cluster id, so the same pool holds N + 1 connections.

Cause:

  • aio/wrapper.py (AsyncAwsWrapperConnection.connect) builds a new host list provider via _build_host_list_provider(...) on every connect.
  • AsyncAuroraHostListProvider._get_or_create_monitor() (aio/host_list_provider.py) stores the monitor on the provider instance (self._monitor). It isn't shared across providers with the same cluster id.
  • Sync RdsHostListProvider._get_or_create_monitor() (host_list_provider.py) uses monitor_service.run_if_absent(ClusterTopologyMonitorImpl, self.get_cluster_id(), ...), so it is shared.

There's a second problem: closing the connection doesn't stop its monitor. AsyncPluginServiceImpl.release_resources() only releases the host list provider when it is an AsyncCanReleaseResources, and AsyncAuroraHostListProvider isn't one. The monitor is only stopped by release_resources_async() at shutdown. Under a pool that replaces connections (failover, pool_pre_ping invalidation, pool_recycle), monitoring connections build up over time.

Expected Behavior

As in the sync wrapper, connections to the same cluster share one topology monitor and one monitoring connection, and the monitor stops once no connection uses it.

What plugins are used? What other connection properties were set?

wrapper_dialect=aurora-pg&wrapper_plugins=failover,host_monitoring_v2 via create_async_engine("postgresql+aws_wrapper_psycopg://..."). Any topology-aware plugin triggers it. host_monitoring_v2 alone does not, because its monitors are already shared per host.

Current Behavior

A user reported that with an async SQLAlchemy engine and a pool of 10 connections, Aurora PostgreSQL showed 20 connections from the app. The sync wrapper showed 11 for the same setup.

The script below reproduces it without a database:

app connections:            10
distinct cluster ids:       1
running topology monitors:  10
monitor connections opened: 10
Reproduction Steps
import asyncio
from unittest.mock import AsyncMock, MagicMock

from aws_advanced_python_wrapper.aio import release_resources_async
from aws_advanced_python_wrapper.aio.host_list_provider import \
    AsyncAuroraHostListProvider
from aws_advanced_python_wrapper.utils.properties import Properties

POOL_SIZE = 10
monitor_conns_opened = 0


async def monitor_conn_factory():
    # Stands in for aio/wrapper.py's _monitor_conn_factory.
    global monitor_conns_opened
    monitor_conns_opened += 1
    return MagicMock()


async def main():
    props = Properties({"host": "db.cluster-xyz.us-east-1.rds.amazonaws.com",
                        "port": "5432", "plugins": "failover"})
    providers = []
    for i in range(POOL_SIZE):
        # aio/wrapper.py builds a new provider on every connect.
        driver_dialect = MagicMock()
        driver_dialect.is_closed = AsyncMock(return_value=False)
        p = AsyncAuroraHostListProvider(
            props, driver_dialect, monitor_connection_factory=monitor_conn_factory)
        try:
            await p.refresh(MagicMock())  # what connect does
        except Exception:
            pass  # the fake connection can't run the topology query
        providers.append(p)
    await asyncio.sleep(0.5)
    running = sum(1 for p in providers if p._monitor is not None and p._monitor.is_running())
    print(f"app connections:            {POOL_SIZE}")
    print(f"distinct cluster ids:       {len({p.get_cluster_id() for p in providers})}")
    print(f"running topology monitors:  {running}")
    print(f"monitor connections opened: {monitor_conns_opened}")
    await release_resources_async()

asyncio.run(main())
Possible Solution

Share AsyncClusterTopologyMonitor per cluster id in a module-level registry, the way aio/host_monitoring_plugin.py already shares EFM monitors per host. Add release_resources() to the async topology providers so closing a connection releases its reference, and stop the monitor when the last reference is released.

Additional Information/Context

Found while helping a user who moved from psycopg's AsyncConnectionPool to an async SQLAlchemy engine. I'm working on a fix and will open a PR that references this issue.

The AWS Advanced Python Wrapper version used

main at c2cd657 (async API, not yet released)

python version used

Python 3.14

Operating System and version

macOS (reproduced locally); the user's environment wasn't stated

Vorherrschende Sprache
Python
Sterne
99
Forks
22
Ø Merge
1 T. 7 Std.
Gemergte PRs (30 T.)
4

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus aws/aws-advanced-python-wrapper

Alle Issues in aws/aws-advanced-python-wrapper

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.