withAuthTab() fails with HTTPS (App Links) callbacks because CustomTabsController calls the custom-scheme AuthTabIntent.launch() overload
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 58/100
- Issue-Typ
- Bug
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Bereich
- authentication, mobile
Rechercherichtung
Read CustomTabsController.launchAsAuthTab() and the Auth Tab API usage in LogoutManager; compare how the SDK handles custom-scheme redirects with the documented HTTPS overload. Trace the existing Auth Tab tests and add coverage for HTTPS host and path handling in both login and logout. Done means HTTPS App Links deliver the callback successfully while custom-scheme redirects continue to work.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Checklist
- The issue can be reproduced in the Auth0.Android sample app (or N/A).
- I have looked into the Readme, Examples, and FAQ and have not found a suitable solution or answer.
- I have looked into the API documentation and have not found a suitable solution or answer.
- I have searched the issues and have not found a suitable solution or answer.
- I have searched the Auth0 Community forums and have not found a suitable solution or answer.
- I agree to the terms within the Auth0 Code of Conduct.
Description
When using WebAuthProvider.login(account).withScheme("https").withAuthTab(), authentication fails to return credentials to the app after the user completes login in the Auth Tab, and instead fails with a0.authentication_canceled ("The user closed the browser app and the authentication was canceled.").
According to examples/auth-tab.md, Auth Tab supports both custom URI schemes and HTTPS (Android App Links) redirects verified through Digital Asset Links.
However, in CustomTabsController.launchAsAuthTab(), the SDK extracts only scheme and unconditionally calls the 3-argument custom-scheme overload of AuthTabIntent.launch():
String scheme = Uri.parse(redirectUri).getScheme();
AuthTabIntent authTabIntent = builder.build();
threadSwitcher.mainThread(() -> authTabIntent.launch(authTabLauncher, uri, scheme));
In androidx.browser:browser:1.10.0, AuthTabIntent has two distinct launch() overloads:
1. launch(launcher, uri, redirectScheme) — sets EXTRA_REDIRECT_SCHEME (must only be used for custom schemes).
2. launch(launcher, uri, redirectHost, redirectPath) — sets EXTRA_HTTPS_REDIRECT_HOST and EXTRA_HTTPS_REDIRECT_PATH (required for https redirects).
Because EXTRA_HTTPS_REDIRECT_HOST and EXTRA_HTTPS_REDIRECT_PATH are never set when scheme is "https", Chrome’s AuthTabIntentDataProvider / AuthTabVerifier does not recognize the HTTPS callback URL as the Auth Tab redirect target:
- Chrome’s
AuthTabVerifier.isCustomScheme(url)returns false because https is a standard web scheme(UrlUtilities.isAcceptedScheme(url) == true). - Chrome’s
AuthTabVerifier.shouldRedirectHttpsAuthUrl(url)returns false becauseEXTRA_HTTPS_REDIRECT_HOSTandEXTRA_HTTPS_REDIRECT_PATHwere null. - Instead of finishing the Auth Tab via
setResult(RESULT_OK, intent), Chrome falls through to standard Android App Links handling and startsRedirectActivity. RedirectActivitystarts AuthenticationActivity withFLAG_ACTIVITY_CLEAR_TOP | FLAG_ACTIVITY_SINGLE_TOP, which force-finishes the child Auth Tab activity on top ofAuthenticationActivity.- Android delivers
RESULT_CANCELEDtoAuthenticationActivity'sauthTabLauncherbeforeonResume(), causingAuthTabResultHandlerto deliver a cancellationresult (Intent())and callfinish(), dropping the redirect data fromRedirectActivity.
Expected behavior: When the parsed redirectUri has scheme "https", CustomTabsController.launchAsAuthTab() (and LogoutManager when using returnTo) should extract host and path from redirectUri and call the 4-argument overload:
Uri parsedRedirect = Uri.parse(redirectUri);
String scheme = parsedRedirect.getScheme();
if ("https".equalsIgnoreCase(scheme)) {
String host = parsedRedirect.getHost();
String path = parsedRedirect.getPath();
// validate host and path are non-empty, then:
threadSwitcher.mainThread(() -> authTabIntent.launch(authTabLauncher, uri, host, path));
} else {
threadSwitcher.mainThread(() -> authTabIntent.launch(authTabLauncher, uri, scheme));
}
Reproduction
Consistently reproducible (100% of attempts):
-
Configure an Android app with verified HTTPS Android App Links (autoVerify="true" on RedirectActivity, matching assetlinks.json verified on-device via adb shell pm get-app-links).
-
Start login with Auth Tab and HTTPS scheme:
WebAuthProvider.login(account)
.withScheme("https")
.withAuthTab()
.withEphemeralBrowsing()
.await(activity)
- Complete sign-in on Universal Login inside the Chrome Auth Tab.
- Observe that when Auth0 redirects to https:///android//callback?code=..., RedirectActivity is launched instead of
authTabLauncherreceivingRESULT_OK, andWebAuthProviderthrowsAuthenticationExceptionwithisCanceled == true (a0.authentication_canceled).
Additional context
-
Dependencies: com.auth0.android:auth0:4.3.0, androidx.browser:browser:1.10.0
-
Browser: Chrome 156 (also affects Chrome 137+)
-
Removing .withAuthTab() (using standard Custom Tabs with the exact same HTTPS App Link configuration) succeeds immediately.
-
Also confirmed present on main and v5_development (5.0.0-beta.2).
Auth0.Android version:4.3.0(also affects4.0.0-beta.1through5.0.0-beta.2)
Android version(s): Android 13 (API 33), Samsung SM-G991U (reproduces on any Android 12+ device with Chrome 137+)
Auth0.Android version
4.3.0
Android version(s)
13-17
- Vorherrschende Sprache
- Kotlin
- Sterne
- 303
- Forks
- 182
- Ø Merge
- 18 Std. 42 Min.
- Gemergte PRs (30 T.)
- 36
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus auth0/Auth0.Android
-
feature request
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 35/100
auth0/Auth0.Android#1136 · 1 Kommentar · 1 Reaktion ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 54/100
auth0/Auth0.Android#1127 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
SecureCredentialsManager serves expired access tokens for up to an hour after the autumn DST transitionEvtl. vergeben @utkrishtsahu hat das vor 15 Tagen übernommen. Offenbug
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 57/100
auth0/Auth0.Android#1113 · 1 Kommentar · 1 Reaktion · 1 zugewiesene Person ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 28/100
auth0/Auth0.Android#1093 · 5 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in auth0/Auth0.Android
Ähnliche Issues
-
hoglite
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 1 Tag
-
Android: with view recycling on, a recycled View keeps its nextFocusLeftEvtl. vergeben Ein verknüpfter Pull Request ist offen oder bereits gemergt. OffenNeeds: Triage :mag: Platform: Android
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
react/react-native#60167 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
ankidroid/Anki-Android#23557 ·
Maintainer antworten meist innerhalb von 1 Tag
-
CI/CD ⚒️ Flaky-tests 🐦 python 🐍
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
valkey-io/valkey-glide#7804 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Maintainer antworten meist innerhalb von 1 Tag