withAuthTab() fails with HTTPS (App Links) callbacks because CustomTabsController calls the custom-scheme AuthTabIntent.launch() overload

Đang mở
#1,130 1 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
58/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
android, kotlin
Lĩnh vực
authentication, mobile

Hướng nghiên cứu

Read CustomTabsController.launchAsAuthTab() and the Auth Tab API usage in LogoutManager; compare how the SDK handles custom-scheme redirects with the documented HTTPS overload. Trace the existing Auth Tab tests and add coverage for HTTPS host and path handling in both login and logout. Done means HTTPS App Links deliver the callback successfully while custom-scheme redirects continue to work.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

bug
Checklist
Description

When using WebAuthProvider.login(account).withScheme("https").withAuthTab(), authentication fails to return credentials to the app after the user completes login in the Auth Tab, and instead fails with a0.authentication_canceled ("The user closed the browser app and the authentication was canceled.").

According to examples/auth-tab.md, Auth Tab supports both custom URI schemes and HTTPS (Android App Links) redirects verified through Digital Asset Links.

However, in CustomTabsController.launchAsAuthTab(), the SDK extracts only scheme and unconditionally calls the 3-argument custom-scheme overload of AuthTabIntent.launch():

String scheme = Uri.parse(redirectUri).getScheme();

AuthTabIntent authTabIntent = builder.build();
threadSwitcher.mainThread(() -> authTabIntent.launch(authTabLauncher, uri, scheme));

In androidx.browser:browser:1.10.0, AuthTabIntent has two distinct launch() overloads:

1. launch(launcher, uri, redirectScheme) — sets EXTRA_REDIRECT_SCHEME (must only be used for custom schemes).
2. launch(launcher, uri, redirectHost, redirectPath) — sets EXTRA_HTTPS_REDIRECT_HOST and EXTRA_HTTPS_REDIRECT_PATH (required for https redirects).

Because EXTRA_HTTPS_REDIRECT_HOST and EXTRA_HTTPS_REDIRECT_PATH are never set when scheme is "https", Chrome’s AuthTabIntentDataProvider / AuthTabVerifier does not recognize the HTTPS callback URL as the Auth Tab redirect target:

  1. Chrome’s AuthTabVerifier.isCustomScheme(url) returns false because https is a standard web scheme (UrlUtilities.isAcceptedScheme(url) == true).
  2. Chrome’s AuthTabVerifier.shouldRedirectHttpsAuthUrl(url) returns false because EXTRA_HTTPS_REDIRECT_HOST and EXTRA_HTTPS_REDIRECT_PATH were null.
  3. Instead of finishing the Auth Tab via setResult(RESULT_OK, intent), Chrome falls through to standard Android App Links handling and starts RedirectActivity.
  4. RedirectActivity starts AuthenticationActivity with FLAG_ACTIVITY_CLEAR_TOP | FLAG_ACTIVITY_SINGLE_TOP, which force-finishes the child Auth Tab activity on top of AuthenticationActivity.
  5. Android delivers RESULT_CANCELED to AuthenticationActivity's authTabLauncher before onResume(), causing AuthTabResultHandler to deliver a cancellation result (Intent()) and call finish(), dropping the redirect data from RedirectActivity.

Expected behavior: When the parsed redirectUri has scheme "https", CustomTabsController.launchAsAuthTab() (and LogoutManager when using returnTo) should extract host and path from redirectUri and call the 4-argument overload:

Uri parsedRedirect = Uri.parse(redirectUri);
String scheme = parsedRedirect.getScheme();
if ("https".equalsIgnoreCase(scheme)) {
    String host = parsedRedirect.getHost();
    String path = parsedRedirect.getPath();
    // validate host and path are non-empty, then:
    threadSwitcher.mainThread(() -> authTabIntent.launch(authTabLauncher, uri, host, path));
} else {
    threadSwitcher.mainThread(() -> authTabIntent.launch(authTabLauncher, uri, scheme));
}

Reproduction

Consistently reproducible (100% of attempts):

  1. Configure an Android app with verified HTTPS Android App Links (autoVerify="true" on RedirectActivity, matching assetlinks.json verified on-device via adb shell pm get-app-links).

  2. Start login with Auth Tab and HTTPS scheme:

WebAuthProvider.login(account)
    .withScheme("https")
    .withAuthTab()
    .withEphemeralBrowsing()
    .await(activity)
  1. Complete sign-in on Universal Login inside the Chrome Auth Tab.
  2. Observe that when Auth0 redirects to https:///android//callback?code=..., RedirectActivity is launched instead of authTabLauncher receiving RESULT_OK, and WebAuthProvider throws AuthenticationException with isCanceled == true (a0.authentication_canceled).
Additional context
  • Dependencies: com.auth0.android:auth0:4.3.0, androidx.browser:browser:1.10.0

  • Browser: Chrome 156 (also affects Chrome 137+)

  • Removing .withAuthTab() (using standard Custom Tabs with the exact same HTTPS App Link configuration) succeeds immediately.

  • Also confirmed present on main and v5_development (5.0.0-beta.2).
    Auth0.Android version: 4.3.0 (also affects 4.0.0-beta.1 through 5.0.0-beta.2)

Android version(s): Android 13 (API 33), Samsung SM-G991U (reproduces on any Android 12+ device with Chrome 137+)

Auth0.Android version

4.3.0

Android version(s)

13-17

Ngôn ngữ chính
Kotlin
Star
303
Fork
182
Merge trung bình
18 giờ 42 phút
Pull request đã merge (30 ngày)
36

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của auth0/Auth0.Android

Tất cả issue của auth0/Auth0.Android

Issue tương tự

Thêm issue về Kotlin

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.