Rewrite escaped-regex error checks in sqllogictest files as plain text

Offen
  • Stimmt etwas nicht?
#27,239 6 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@IG-ABHINAV arbeitet bereits daran.

Seit 09.11.2026.

  • #27263 von @IG-ABHINAV — offen
  • #27336 von @cblp — offen

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
54/100
Issue-Typ
Refactoring
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
rust
Bereich
testing

Rechercherichtung

Start with the listed git grep command to find matching records in datafusion/sqllogictest/test_files/*.slt, then read the sqllogictest README guidance from #27217. Convert a small batch of 5–10 files and run cargo test --test sqllogictests -- <file> --complete on files that already pass. Keep only blocks whose messages match the old regex with escapes removed; review git diff to confirm only intended records changed.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

enhancement good first issue
Is your feature request related to a problem or challenge?

326 error checks in 65 .slt files put the full error message on the statement error / query error line as an escaped regex, which is hard to read and review:

statement error DataFusion error: This feature is not implemented: WITH \[NO\] DATA not supported
CREATE TABLE foo AS SELECT 1 WITH NO DATA;

As plain text after ----, the same check is exact and readable:

statement error
CREATE TABLE foo AS SELECT 1 WITH NO DATA;
----
DataFusion error: This feature is not implemented: WITH [NO] DATA not supported

#27217 documents this form in the sqllogictest README, and #27218 asks --complete to write it for new records. Neither changes existing lines, because --complete leaves a regex that still matches alone. This issue is about converting the existing lines.

Describe the solution you'd like

For each line listed by this command:

git grep -nE '^(statement|query) error DataFusion error: .*\\[][(){}.+*?^$|]' -- 'datafusion/sqllogictest/test_files/*.slt'
  1. Remove the message from the statement error / query error line, and add ---- and two blank lines after the SQL. With only one blank line, the next record becomes part of the expected error and --complete deletes it.
  2. Run cargo test --test sqllogictests -- <file> --complete.
  3. Keep the new block only if its message equals the old regex with the escapes removed. If it differs, the regex matched part of the message on purpose, so restore the old line. For example, ddl.slt:704 uses .* for a local path.
  4. Check git diff: only the converted records should change. Start from a file that passes, because --complete also rewrites any other failing record.

Several small PRs (about 5 to 10 files each) are easier to review and conflict less: 36 open PRs touch 21 of these files today. Please comment here with the files you're taking.

The 75 other escaped lines don't start with DataFusion error:, so they match only part of a message. Leave them as they are.

Describe alternatives you've considered
  • One PR for all 65 files: a harder review, and more conflicts with open PRs.
  • Waiting for #27218: it changes only what --complete writes for failing records, so existing lines that pass stay as they are.
Additional context

Follow-up to #27217.

The steps above, tried on ddl.slt (7 lines)

4 lines converted cleanly, for example:

-statement error DataFusion error: Execution error: Catalog 'cat' doesn't exist\.
+statement error
 drop catalog cat;
+----
+DataFusion error: Execution error: Catalog 'cat' doesn't exist.
+

The 3 No files found at .* lines were filled with the local path (file:///.../test_files/scratch/ddl/empty_dir/), so step 3 restores them.

Willingness to contribute

I'm not planning to work on this myself, so anyone is welcome to pick it up. Feel free to ping me with questions or when you'd like a review.

Vorherrschende Sprache
Rust
Sterne
9.6k
Forks
2.6k
Ø Merge
3 T. 4 Std.
Gemergte PRs (30 T.)
345

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus apache/datafusion

Alle Issues in apache/datafusion

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.