Rewrite escaped-regex error checks in sqllogictest files as plain text

Aperta
  • Qualcosa non va?
#27,239 6 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@IG-ABHINAV ci sta già lavorando.

Dal 9/11/2026.

  • #27263 di @IG-ABHINAV — aperta
  • #27336 di @cblp — aperta

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
54/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
testing

Direzione di ricerca

Start with the listed git grep command to find matching records in datafusion/sqllogictest/test_files/*.slt, then read the sqllogictest README guidance from #27217. Convert a small batch of 5–10 files and run cargo test --test sqllogictests -- <file> --complete on files that already pass. Keep only blocks whose messages match the old regex with escapes removed; review git diff to confirm only intended records changed.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement good first issue
Is your feature request related to a problem or challenge?

326 error checks in 65 .slt files put the full error message on the statement error / query error line as an escaped regex, which is hard to read and review:

statement error DataFusion error: This feature is not implemented: WITH \[NO\] DATA not supported
CREATE TABLE foo AS SELECT 1 WITH NO DATA;

As plain text after ----, the same check is exact and readable:

statement error
CREATE TABLE foo AS SELECT 1 WITH NO DATA;
----
DataFusion error: This feature is not implemented: WITH [NO] DATA not supported

#27217 documents this form in the sqllogictest README, and #27218 asks --complete to write it for new records. Neither changes existing lines, because --complete leaves a regex that still matches alone. This issue is about converting the existing lines.

Describe the solution you'd like

For each line listed by this command:

git grep -nE '^(statement|query) error DataFusion error: .*\\[][(){}.+*?^$|]' -- 'datafusion/sqllogictest/test_files/*.slt'
  1. Remove the message from the statement error / query error line, and add ---- and two blank lines after the SQL. With only one blank line, the next record becomes part of the expected error and --complete deletes it.
  2. Run cargo test --test sqllogictests -- <file> --complete.
  3. Keep the new block only if its message equals the old regex with the escapes removed. If it differs, the regex matched part of the message on purpose, so restore the old line. For example, ddl.slt:704 uses .* for a local path.
  4. Check git diff: only the converted records should change. Start from a file that passes, because --complete also rewrites any other failing record.

Several small PRs (about 5 to 10 files each) are easier to review and conflict less: 36 open PRs touch 21 of these files today. Please comment here with the files you're taking.

The 75 other escaped lines don't start with DataFusion error:, so they match only part of a message. Leave them as they are.

Describe alternatives you've considered
  • One PR for all 65 files: a harder review, and more conflicts with open PRs.
  • Waiting for #27218: it changes only what --complete writes for failing records, so existing lines that pass stay as they are.
Additional context

Follow-up to #27217.

The steps above, tried on ddl.slt (7 lines)

4 lines converted cleanly, for example:

-statement error DataFusion error: Execution error: Catalog 'cat' doesn't exist\.
+statement error
 drop catalog cat;
+----
+DataFusion error: Execution error: Catalog 'cat' doesn't exist.
+

The 3 No files found at .* lines were filled with the local path (file:///.../test_files/scratch/ddl/empty_dir/), so step 3 restores them.

Willingness to contribute

I'm not planning to work on this myself, so anyone is welcome to pick it up. Feel free to ping me with questions or when you'd like a review.

Lingua principale
Rust
Stelle
9.6k
Fork
2.6k
Merge medio
3g 4h
PR unite (30g)
345

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apache/datafusion

Tutte le issue di apache/datafusion

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.