Canary builds are named after the release candidate, so npm ranks them above it
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Anfängerfreundlichkeit
- 74/100
- Issue-Typ
- Bug
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- shell
- Bereich
- build-system, release
Rechercherichtung
Beginne mit dem root package.json und tools/build.sh und verfolge anschließend, wie Versionen für Canary- und getaggte Release-Builds ausgewählt werden. Bestätige die resultierenden Paketversionen anhand der npm-semver-Reihenfolge, wobei Canaries unter dem Release Candidate eingestuft werden, während getaggte Releases ihre Tag-Versionen beibehalten.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
ng add @angular/fire@next and ng update @angular/fire@next install a canary, not the release candidate.
When #3674 was merged, 21.0.0-rc.0 was put in package.json, breaking with this repo's previous patterns. #3751 continued this break with 21.0.0-rc.1.
#3709 mitigated the symptom for ng add by writing the exact installed version into the user's package.json. But going back to the old pattern would simplify things further.
Details
- The root
package.jsonversion field holds21.0.0-rc.1, andtools/build.shspecifies each canary by appending-canary.<short sha>to that field.- Every merge to main therefore publishes
21.0.0-rc.1-canary.<sha>, which semver ranks above21.0.0-rc.1, because the middle identifier parses as the text1-canaryand text outranks a number.
- Every merge to main therefore publishes
ng add @angular/fire@nextinstalls a canary, not the release candidate. The Angular CLI resolves the tag, then writes the range^21.0.0-rc.1, and npm resolves that to21.0.0-rc.1-canary.95b3de1.ng update @angular/fire@nextdoes the same, and unlikeng addit leaves a range inpackage.jsonrather than an exact version, so the app can drift again on any later install.- The version field is not what a tagged release publishes.
tools/build.shtakes a tagged release's version from the tag name.- At the
19.0.0-rc.5tag the version field inpackage.jsonread19.0.0, yet the release published to npm from that tag is19.0.0-rc.5. - At the
20.0.1tag the field read20.0.0and the release published to npm is20.0.1.
- At the
- Releases through v20 named canaries after the release itself, for example
19.0.0-canary.<sha>, which ranks below every19.0.0-rc.N.- The release-candidate string first entered the version field in the v21 preparation commit (#3674).
Scope
Build and packaging. It does not remove the 25 canary builds already published on the 21 line, which keep outranking 21.0.0-rc.1 until 21.0.0 ships.
- Vorherrschende Sprache
- TypeScript
- Sterne
- 7.8k
- Forks
- 2.2k
- Ø Merge
- 3 T. 6 Std.
- Gemergte PRs (30 T.)
- 5
Beitragsleitfaden
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus angular/angularfire
-
comp: schematics type: bug version: current (v17+)
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 76/100
angular/angularfire#3768 ·
-
comp: docs type: chore version: current (v17+)
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 58/100
angular/angularfire#3764 ·
-
comp: firestore comp: ssr priority: P0 (critical) type: feature version: current (v17+)
angular/angularfire#3757 · 1 zugewiesene Person ·
-
Six `firebase` entry points have no `@angular/fire` equivalent, so their exports are unreachable Offencomp: core type: feature
angular/angularfire#3755 · 1 zugewiesene Person ·
-
comp: auth comp: ssr comp: zones type: bug
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 76/100
angular/angularfire#3748 ·
Alle Issues in angular/angularfire
Ähnliche Issues
-
blocklist removal
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
MetaMask/eth-phishing-detect#296544 ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
pastelsky/bundlephobia#1122 ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
-
category/development priority/P2 scope/file-operations scope/testing type/enhancement
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
-
Enatega Customer and Rider app: Add-ons price is not visible to customer after order is placed. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100