Canary builds are named after the release candidate, so npm ranks them above it
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 2/5
- Tempo estimado
- 1-3 horas
- Facilidade para iniciantes
- 74/100
- Tipo de issue
- Bug
- Clareza
- Claramente especificada
- Status de atividade
- Ativa
- Stack de tecnologia
- shell
- Domínio
- build-system, release
Direção de pesquisa
Comece pelo package.json raiz e por tools/build.sh; em seguida, rastreie como as versões são selecionadas para os builds Canary e os builds de release com tag. Confirme as versões de pacote resultantes de acordo com a ordenação semver do npm, garantindo que os Canaries fiquem abaixo da release candidate, enquanto os releases com tag mantenham suas versões de tag.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
ng add @angular/fire@next and ng update @angular/fire@next install a canary, not the release candidate.
When #3674 was merged, 21.0.0-rc.0 was put in package.json, breaking with this repo's previous patterns. #3751 continued this break with 21.0.0-rc.1.
#3709 mitigated the symptom for ng add by writing the exact installed version into the user's package.json. But going back to the old pattern would simplify things further.
Details
- The root
package.jsonversion field holds21.0.0-rc.1, andtools/build.shspecifies each canary by appending-canary.<short sha>to that field.- Every merge to main therefore publishes
21.0.0-rc.1-canary.<sha>, which semver ranks above21.0.0-rc.1, because the middle identifier parses as the text1-canaryand text outranks a number.
- Every merge to main therefore publishes
ng add @angular/fire@nextinstalls a canary, not the release candidate. The Angular CLI resolves the tag, then writes the range^21.0.0-rc.1, and npm resolves that to21.0.0-rc.1-canary.95b3de1.ng update @angular/fire@nextdoes the same, and unlikeng addit leaves a range inpackage.jsonrather than an exact version, so the app can drift again on any later install.- The version field is not what a tagged release publishes.
tools/build.shtakes a tagged release's version from the tag name.- At the
19.0.0-rc.5tag the version field inpackage.jsonread19.0.0, yet the release published to npm from that tag is19.0.0-rc.5. - At the
20.0.1tag the field read20.0.0and the release published to npm is20.0.1.
- At the
- Releases through v20 named canaries after the release itself, for example
19.0.0-canary.<sha>, which ranks below every19.0.0-rc.N.- The release-candidate string first entered the version field in the v21 preparation commit (#3674).
Scope
Build and packaging. It does not remove the 25 canary builds already published on the 21 line, which keep outranking 21.0.0-rc.1 until 21.0.0 ships.
- Linguagem predominante
- TypeScript
- Estrelas
- 7.8k
- Forks
- 2.2k
- Merge médio
- 3d 6h
- PRs com merge (30d)
- 5
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de angular/angularfire
-
comp: schematics type: bug version: current (v17+)
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 76/100
angular/angularfire#3768 ·
-
comp: docs type: chore version: current (v17+)
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 58/100
angular/angularfire#3764 ·
-
comp: firestore comp: ssr priority: P0 (critical) type: feature version: current (v17+)
angular/angularfire#3757 · 1 responsável ·
-
Six `firebase` entry points have no `@angular/fire` equivalent, so their exports are unreachable Abertacomp: core type: feature
angular/angularfire#3755 · 1 responsável ·
-
comp: auth comp: ssr comp: zones type: bug
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 76/100
angular/angularfire#3748 ·
Todas as issues de angular/angularfire
Issues semelhantes
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
vercel-labs/just-bash#464 ·
-
looksLikeSlug() is ASCII-only, so non-Latin entity slugs (e.g. Korean) skip exact match and collapse Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 65/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 65/100
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 90/100
TanStack/tanstack.com#1293 ·