Unhelpful errors on syntax issues
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 45/100
- Issue-Typ
- Feature
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Ruhig
- Tech-Stack
- github-actions, javascript, typescript
- Bereich
- ci-cd, developer-experience, tooling
Rechercherichtung
Start from the script execution path represented by callAsyncFunction and main in the reported dist/index.js stack, and trace how syntax errors from the action code are surfaced. Done means syntax errors identify the relevant line in the supplied script, ideally including the source line, with tests covering the improved output.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Is your feature request related to a problem? Please describe.
Currently problems with action code can cause errors like this:
SyntaxError: Unexpected token '.'
at new AsyncFunction (<anonymous>)
at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:[35](https://github.com/dktapps/RestrictedActions/actions/runs/11989435916/job/33425884775#step:4:36)424:16)
at main (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35522:26)
at /home/runner/work/_actions/actions/github-script/v7/dist/index.js:35497:1
at /home/runner/work/_actions/actions/github-script/v7/dist/index.js:35553:3
at Object.<anonymous> (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35556:12)
at Module._compile (node:internal/modules/cjs/loader:1358:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
at Module.load (node:internal/modules/cjs/loader:1208:32)
at Module._load (node:internal/modules/cjs/loader:1024:12)
I haven't the faintest clue where or why this happened with my code. Plugging it into a linter didn't reveal any problems.
It would be nice if the error output included a line number in the actual action code to show where the problem occurred, or even better printed the line in question.
Here's the code this happened with, if it's relevant:
- name: "Check if bot's review was dismissed (pull_request_review.dismissed only)"
id: re-review
uses: actions/github-script@v7
env:
APP_SLUG: ${{ steps.generate-token.outputs.app-slug }}
REVIEWER_ID: ${{ github.event.client_payload.reviewer_id }}
with:
github-token: ${{ steps.generate-token.outputs.token }}
script: |
const reviewer_id = process.env.REVIEWER_ID;
console.log(reviewer_id);
if (reviewer_id === "0") {
console.log("No reviewer ID provided, continuing with re-review");
core.setOutput('skip', 'false');
} else {
console.log("Reviewer ID provided: " + reviewer_id);
const user_info = await github.rest.users.getByUsername({
process.env.APP_SLUG + '[bot]'
});
const bot_user_id = user_info.data.id;
if (bot_user_id != reviewer_id) {
console.log(`Not the bot's review that was dismissed (expected user ID: ${bot_user_id}, got: ${reviewer_id})`);
console.log('Skipping re-review');
core.setOutput('skip', 'true');
} else {
console.log("Bot's review was dismissed, continuing with re-review");
core.setOutput('skip', 'false');
}
}
Describe the solution you'd like
It would be nice if the error output included a line number in the actual action code to show where the problem occurred, or even better printed the line in question.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
- Vorherrschende Sprache
- TypeScript
- Sterne
- 5k
- Forks
- 586
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus actions/github-script
-
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 48/100
actions/github-script#728 ·
-
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 52/100
actions/github-script#727 · 1 Reaktion ·
-
{ Offen
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 10/100
actions/github-script#724 ·
-
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 55/100
actions/github-script#723 · 1 Kommentar ·
-
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 55/100
actions/github-script#714 · 1 Kommentar · 4 Reaktionen ·
Alle Issues in actions/github-script
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
-
bug v2
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
modelcontextprotocol/inspector#2458 · 1 Kommentar ·
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 75/100
railmapgen/rmp-gallery#4068 ·
-
Mend: dependency security vulnerability status: needs triage 🕵️♀️
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
carbon-design-system/ibm-products#9907 ·