Unhelpful errors on syntax issues
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 45/100
- Type d'issue
- Fonctionnalité
- Clarté
- Plutôt claire
- Activité
- Calme
- Stack technique
- github-actions, javascript, typescript
- Domaine
- ci-cd, developer-experience, tooling
Piste de recherche
Start from the script execution path represented by callAsyncFunction and main in the reported dist/index.js stack, and trace how syntax errors from the action code are surfaced. Done means syntax errors identify the relevant line in the supplied script, ideally including the source line, with tests covering the improved output.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Is your feature request related to a problem? Please describe.
Currently problems with action code can cause errors like this:
SyntaxError: Unexpected token '.'
at new AsyncFunction (<anonymous>)
at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:[35](https://github.com/dktapps/RestrictedActions/actions/runs/11989435916/job/33425884775#step:4:36)424:16)
at main (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35522:26)
at /home/runner/work/_actions/actions/github-script/v7/dist/index.js:35497:1
at /home/runner/work/_actions/actions/github-script/v7/dist/index.js:35553:3
at Object.<anonymous> (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35556:12)
at Module._compile (node:internal/modules/cjs/loader:1358:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
at Module.load (node:internal/modules/cjs/loader:1208:32)
at Module._load (node:internal/modules/cjs/loader:1024:12)
I haven't the faintest clue where or why this happened with my code. Plugging it into a linter didn't reveal any problems.
It would be nice if the error output included a line number in the actual action code to show where the problem occurred, or even better printed the line in question.
Here's the code this happened with, if it's relevant:
- name: "Check if bot's review was dismissed (pull_request_review.dismissed only)"
id: re-review
uses: actions/github-script@v7
env:
APP_SLUG: ${{ steps.generate-token.outputs.app-slug }}
REVIEWER_ID: ${{ github.event.client_payload.reviewer_id }}
with:
github-token: ${{ steps.generate-token.outputs.token }}
script: |
const reviewer_id = process.env.REVIEWER_ID;
console.log(reviewer_id);
if (reviewer_id === "0") {
console.log("No reviewer ID provided, continuing with re-review");
core.setOutput('skip', 'false');
} else {
console.log("Reviewer ID provided: " + reviewer_id);
const user_info = await github.rest.users.getByUsername({
process.env.APP_SLUG + '[bot]'
});
const bot_user_id = user_info.data.id;
if (bot_user_id != reviewer_id) {
console.log(`Not the bot's review that was dismissed (expected user ID: ${bot_user_id}, got: ${reviewer_id})`);
console.log('Skipping re-review');
core.setOutput('skip', 'true');
} else {
console.log("Bot's review was dismissed, continuing with re-review");
core.setOutput('skip', 'false');
}
}
Describe the solution you'd like
It would be nice if the error output included a line number in the actual action code to show where the problem occurred, or even better printed the line in question.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
- Langage dominant
- TypeScript
- Étoiles
- 5k
- Forks
- 586
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de actions/github-script
-
Difficulté 3/5 1-2 jours Accessibilité débutants 48/100
actions/github-script#728 ·
-
Difficulté 3/5 1-2 jours Accessibilité débutants 52/100
actions/github-script#727 · 1 réaction ·
-
{ Ouverte
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 10/100
actions/github-script#724 ·
-
Difficulté 3/5 1-2 jours Accessibilité débutants 55/100
actions/github-script#723 · 1 commentaire ·
-
Difficulté 3/5 1-2 jours Accessibilité débutants 55/100
actions/github-script#714 · 1 commentaire · 4 réactions ·
Toutes les issues de actions/github-script
Issues similaires
-
blocklist removal
Difficulté 2/5 1-3 heures Accessibilité débutants 65/100
MetaMask/eth-phishing-detect#296544 ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 70/100
pastelsky/bundlephobia#1122 ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 70/100
-
category/development priority/P2 scope/file-operations scope/testing type/enhancement
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
-
Enatega Customer and Rider app: Add-ons price is not visible to customer after order is placed. Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100