[BUG] get_dependencies in nuget.py crashes with KeyError: '@targetFramework' on dependency groups without targetFramework

Offen
#5,493 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@patelshivani2283-lab arbeitet bereits daran.

Seit 17.11.2026.

  • #5494 von @patelshivani2283-lab — offen

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
35/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
python
Bereich
backend

Rechercherichtung

Start with get_dependencies() in src/packagedcode/nuget.py and inspect the existing NuGet package tests for .nuspec dependency groups and license parsing. The issue also reports that packages.lock.json project references of type Project are rejected; check the related lockfile handling and tests. Reproduce the fallback group crash, then confirm all three reported cases are covered and scans complete without errors.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Description

In NuGet .nuspec manifests, dependency <group> elements can specify target frameworks. According to Microsoft's NuGet nuspec reference documentation:

"A <dependencies> element can contain one <group> tag without a targetFramework attribute to specify a fallback group that is applied when no specific targetFramework matches the project."

Currently, scancode-toolkit's get_dependencies() in src/packagedcode/nuget.py accesses group['@targetFramework'] directly:

for group in groups:
    extra_data = dict(framework=group['@targetFramework'])
    deps = group.get('dependency') or []
    yield from _get_dep_packs(deps, extra_data)

When scanning any .nuspec that includes a fallback <group> without targetFramework, this raises an unhandled KeyError: '@targetFramework' and aborts the scan.

Additionally:

  • When <license type="expression">...</license> is used in .nuspec, xmltodict parses the element as a dictionary ({'@type': 'expression', '#text': '...'}). Because nuspec.get('license') was passed directly, extracted_license_statement received the dictionary, resulting in a stringified mapping rather than extracting the license expression string.
  • In packages.lock.json, project references with "type": "Project" were not recognized, raising Exception: Unknown package type: Project.
How To Reproduce
  1. Create a test.nuspec with a fallback group:
<?xml version="1.0"?>
<package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
  <metadata>
    <id>SamplePackage</id>
    <version>1.0.0</version>
    <dependencies>
      <group>
        <dependency id="FallbackDep" version="1.0.0" />
      </group>
      <group targetFramework="net6.0">
        <dependency id="Net6Dep" version="2.0.0" />
      </group>
    </dependencies>
  </metadata>
</package>
  1. Scan the file:
./scancode --package --json - test.nuspec
  1. Observe traceback:
KeyError: '@targetFramework'
Expected Behavior
  • Dependencies in a fallback <group> without targetFramework should be extracted without crashing.
  • extra_data['framework'] should be set when targetFramework is present, or omitted when absent.
  • The <license> element text should be cleanly extracted even when attributes like type="expression" are present.
System configuration
  • OS: macOS / Linux / Windows
  • ScanCode version: 33.0.0rc1 / develop branch
  • Python version: 3.10+
Vorherrschende Sprache
Python
Sterne
2.7k
Forks
871
Ø Merge
1 T. 10 Std.
Gemergte PRs (30 T.)
3

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus aboutcode-org/scancode-toolkit

Alle Issues in aboutcode-org/scancode-toolkit

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.