[BUG] get_dependencies in nuget.py crashes with KeyError: '@targetFramework' on dependency groups without targetFramework

Ouverte
#5,493 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@patelshivani2283-lab y travaille déjà.

Depuis le 17/11/2026.

  • #5494 par @patelshivani2283-lab — ouverte

Évaluation

Difficulté
4/5
Temps estimé
1-2 jours
Accessibilité débutants
35/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
À l'abandon
Stack technique
python
Domaine
backend

Piste de recherche

Start with get_dependencies() in src/packagedcode/nuget.py and inspect the existing NuGet package tests for .nuspec dependency groups and license parsing. The issue also reports that packages.lock.json project references of type Project are rejected; check the related lockfile handling and tests. Reproduce the fallback group crash, then confirm all three reported cases are covered and scans complete without errors.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Description

In NuGet .nuspec manifests, dependency <group> elements can specify target frameworks. According to Microsoft's NuGet nuspec reference documentation:

"A <dependencies> element can contain one <group> tag without a targetFramework attribute to specify a fallback group that is applied when no specific targetFramework matches the project."

Currently, scancode-toolkit's get_dependencies() in src/packagedcode/nuget.py accesses group['@targetFramework'] directly:

for group in groups:
    extra_data = dict(framework=group['@targetFramework'])
    deps = group.get('dependency') or []
    yield from _get_dep_packs(deps, extra_data)

When scanning any .nuspec that includes a fallback <group> without targetFramework, this raises an unhandled KeyError: '@targetFramework' and aborts the scan.

Additionally:

  • When <license type="expression">...</license> is used in .nuspec, xmltodict parses the element as a dictionary ({'@type': 'expression', '#text': '...'}). Because nuspec.get('license') was passed directly, extracted_license_statement received the dictionary, resulting in a stringified mapping rather than extracting the license expression string.
  • In packages.lock.json, project references with "type": "Project" were not recognized, raising Exception: Unknown package type: Project.
How To Reproduce
  1. Create a test.nuspec with a fallback group:
<?xml version="1.0"?>
<package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
  <metadata>
    <id>SamplePackage</id>
    <version>1.0.0</version>
    <dependencies>
      <group>
        <dependency id="FallbackDep" version="1.0.0" />
      </group>
      <group targetFramework="net6.0">
        <dependency id="Net6Dep" version="2.0.0" />
      </group>
    </dependencies>
  </metadata>
</package>
  1. Scan the file:
./scancode --package --json - test.nuspec
  1. Observe traceback:
KeyError: '@targetFramework'
Expected Behavior
  • Dependencies in a fallback <group> without targetFramework should be extracted without crashing.
  • extra_data['framework'] should be set when targetFramework is present, or omitted when absent.
  • The <license> element text should be cleanly extracted even when attributes like type="expression" are present.
System configuration
  • OS: macOS / Linux / Windows
  • ScanCode version: 33.0.0rc1 / develop branch
  • Python version: 3.10+
Langage dominant
Python
Étoiles
2.7k
Forks
871
Merge moyen
1 j 10 h
PR mergées (30 j)
3

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de aboutcode-org/scancode-toolkit

Toutes les issues de aboutcode-org/scancode-toolkit

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.