Proposal: don't report MonoScripts as potential duplicates

Offen
#160 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
48/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
csharp, unity
Bereich
data

Rechercherichtung

Start by reading the implementation of view_potential_duplicates and how it gathers content types; the issue does not name a file or test. Compare its MonoScript results with the checked-in LeadingEdgeBuilds/AssetBundles data, where DirectAudioClipReference appears twice. Done means the view no longer reports expected per-file MonoScript copies as potential duplicates, with the issue's Unity change still undecided.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

enhancement

Proposal - depends on a Unity change that is not yet decided.

A change currently under review in Unity would stop Content Directory builds from collecting all MonoScripts into one shared content file. Instead, each content file would embed its own copy of every MonoScript it references. At load time Unity repoints the hosts to one shared MonoScript per class, so the embedded copies are expected duplication by design, not wasted content.

I analyzed a local build with that change (plus local fixes for SerializedFile v27 and ContentLayout v4). Most of UnityDataTool handles it fine: monoscript_view and script_object_view link each MonoScript to its host in the same file. The one noisy result is view_potential_duplicates, which lists the per-file copies as duplicated content:

instances  name                        type        total_size  size  in_files
2          LoadableAudioClipReference  MonoScript  216         108   6150b4ed....cf, e71b9429....cf

In a real project with many ScriptableObject or prefab content files, this would add a MonoScript row for almost every script class and hide the real duplicates.

Proposal

If Unity ships embedded MonoScripts, exclude MonoScript from view_potential_duplicates, or move it to a separate view or note.

AssetBundle builds already work this way: each bundle carries the MonoScripts it uses, and the view already lists them. In the checked-in LeadingEdgeBuilds/AssetBundles data, DirectAudioClipReference appears twice. So the filter would also remove existing noise from AssetBundle analysis, even if the Unity change doesn't land.

The cost of the embedding (mostly the MonoScript TypeTree in each file's header, about 1 KB per file uncompressed in my test) would then be better reported through TypeTree overhead reporting (#127) than through the duplicates view.

Leaving this open until the Unity change is decided. If it doesn't land, the AssetBundle case alone may still justify the change.

Vorherrschende Sprache
C#
Sterne
841
Forks
75
Ø Merge
1 T. 7 Std.
Gemergte PRs (30 T.)
3

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus Unity-Technologies/UnityDataTools

Alle Issues in Unity-Technologies/UnityDataTools

Ähnliche Issues

Weitere Issues zu C#

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.