Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

pnpm check-types only checks 2 of 10 packages, so CI's type gate is mostly empty

Offen
  • Stimmt etwas nicht?
#189 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
72/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
typescript, vite
Bereich
build-system, ci-cd

Rechercherichtung

Start by reading .github/workflows/ci.yml, the root package scripts and turbo.json, then compare the package.json files for the listed apps with genai and @repo/ui. Check each package’s TypeScript project configuration, especially the frontend build setup, before adding the missing checks. Run pnpm run check-types and verify a deliberate type error in http-server or frontend makes it fail.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Backend first issue bug good first issue help wanted

CI presents this as the type-safety gate:

# .github/workflows/ci.yml
      - name: Type-check
        run: pnpm run check-types

But most packages do not define the script, so turbo finds almost nothing to run:

• Packages in scope: @repo/db, @repo/eslint-config, @repo/typescript-config,
                     @repo/ui, admin, admin-server, frontend, genai,
                     http-server, ws-server
• Running check-types in 10 packages
 Tasks:    2 successful, 2 total

Only genai and @repo/ui have it. frontend, http-server, ws-server, admin, admin-server and @repo/db are all skipped, and turbo exits 0 regardless.

Why it matters

A contributor can break every type in http-server or the whole frontend and CI stays green. The step looks like protection and provides almost none — which is worse than having no step, because reviewers trust it.

What a fix looks like

Add the script to each package that is missing it:

"check-types": "tsc --noEmit"

The frontend builds with tsc -b && vite build, so it may want tsc -b --noEmit or its existing project reference instead — worth checking what that package actually needs rather than pasting the same line everywhere.

You will not inherit a pile of errors. I checked both servers before filing:

apps/http-server  tsc --noEmit -> 0 errors
apps/ws-server    tsc --noEmit -> 0 errors

So this is additive. If admin or admin-server turn out to have existing errors, say so in the PR rather than fixing them in the same change — those can be their own issue.

Definition of done
  • pnpm run check-types reports more than 2 total (6+ depending on what you include)
  • A deliberate type error in http-server or frontend makes the command fail
  • CI goes red for that deliberate error, then green once reverted

Good first issue: a few lines of JSON, and it turns a decorative CI step into a real one. Verify it works by breaking a type on purpose before you open the PR.

Vorherrschende Sprache
TypeScript
Sterne
21
Forks
7
Ø Merge
3 Std. 39 Min.
Gemergte PRs (30 T.)
16

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TheCodeHeist-Coder/Rexial

Alle Issues in TheCodeHeist-Coder/Rexial

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.