pnpm check-types only checks 2 of 10 packages, so CI's type gate is mostly empty
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 72/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- typescript, vite
- 领域
- build-system, ci-cd
调研方向
Start by reading .github/workflows/ci.yml, the root package scripts and turbo.json, then compare the package.json files for the listed apps with genai and @repo/ui. Check each package’s TypeScript project configuration, especially the frontend build setup, before adding the missing checks. Run pnpm run check-types and verify a deliberate type error in http-server or frontend makes it fail.
由索引模型根据 Issue 内容生成。
描述
CI presents this as the type-safety gate:
# .github/workflows/ci.yml
- name: Type-check
run: pnpm run check-types
But most packages do not define the script, so turbo finds almost nothing to run:
• Packages in scope: @repo/db, @repo/eslint-config, @repo/typescript-config,
@repo/ui, admin, admin-server, frontend, genai,
http-server, ws-server
• Running check-types in 10 packages
Tasks: 2 successful, 2 total
Only genai and @repo/ui have it. frontend, http-server, ws-server, admin, admin-server and @repo/db are all skipped, and turbo exits 0 regardless.
Why it matters
A contributor can break every type in http-server or the whole frontend and CI stays green. The step looks like protection and provides almost none — which is worse than having no step, because reviewers trust it.
What a fix looks like
Add the script to each package that is missing it:
"check-types": "tsc --noEmit"
The frontend builds with tsc -b && vite build, so it may want tsc -b --noEmit or its existing project reference instead — worth checking what that package actually needs rather than pasting the same line everywhere.
You will not inherit a pile of errors. I checked both servers before filing:
apps/http-server tsc --noEmit -> 0 errors
apps/ws-server tsc --noEmit -> 0 errors
So this is additive. If admin or admin-server turn out to have existing errors, say so in the PR rather than fixing them in the same change — those can be their own issue.
Definition of done
pnpm run check-typesreports more than2 total(6+ depending on what you include)- A deliberate type error in
http-serverorfrontendmakes the command fail - CI goes red for that deliberate error, then green once reverted
Good first issue: a few lines of JSON, and it turns a decorative CI step into a real one. Verify it works by breaking a type on purpose before you open the PR.
- 主要语言
- TypeScript
- 星标
- 21
- 派生
- 7
- 平均合并
- 3 小时 39 分钟
- 30 天内合并 PR
- 16
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
TheCodeHeist-Coder/Rexial 的其他 Issue
-
documentation good first issue help wanted
难度 2/5 1-3 小时 新手友好度 78/100
TheCodeHeist-Coder/Rexial#195 ·
维护者通常 1 天内回复
-
Backend first issue bug help wanted
难度 2/5 1-3 小时 新手友好度 84/100
TheCodeHeist-Coder/Rexial#193 ·
维护者通常 1 天内回复
-
Backend first issue bug good first issue help wanted
难度 2/5 1-3 小时 新手友好度 86/100
TheCodeHeist-Coder/Rexial#192 ·
维护者通常 1 天内回复
-
Backend first issue bug good first issue help wanted
难度 2/5 1-3 小时 新手友好度 82/100
TheCodeHeist-Coder/Rexial#191 ·
维护者通常 1 天内回复
-
good first issue help wanted UI & UX
难度 2/5 1-3 小时 新手友好度 90/100
TheCodeHeist-Coder/Rexial#190 ·
维护者通常 1 天内回复
查看 TheCodeHeist-Coder/Rexial 的全部 Issue
相似的 Issue
-
[Bug]: REST API URL starting with "http" but no scheme (e.g. httpbin.org/get) is not given an http:// prefix可能已有人在做 @ItsDeadlyProgrammer 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
appsmithorg/appsmith#42471 · 1 条评论 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
ehmpathy/rhachet-roles-bhrain#705 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
Status: Triage
难度 2/5 1-3 小时 新手友好度 76/100
mermaid-js/mermaid#8546 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
braintrustdata/braintrust-sdk-javascript#2659 ·
维护者通常 1 天内回复