router.load() resolves before an ancestor boundary's code-split errorComponent is loaded (regression in 1.170.19)

Offen
#8,792 1 Kommentar 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@Sheraff arbeitet bereits daran.

Seit 23.10.2026.

  • #8793 von @sarankumar1325 — ohne Merge geschlossen
  • #8896 von @EnesKartal — offen

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
55/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
react, typescript, vite
Bereich
frontend

Rechercherichtung

Start by tracing router.load() and route chunk loading, especially how an errored child selects an ancestor’s errorComponent; the report points to a regression introduced in 1.170.19 and possibly related to #7926. Use the linked reproducer and its failing test, then compare behavior with 1.170.18. Done means the boundary component is loaded when router.load() resolves and the regression test passes.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Which project does this relate to?

Router

Describe the bug

Since 1.170.19, router.load() can resolve before the chunk for the errorComponent that will actually render has loaded. As a result, the first render after load() suspends and is empty.

This happens when a child's loader throws, the child has no errorComponent, and an ancestor's errorComponent is code-split (which autoCodeSplitting does by default). The errored match only loads its own errorComponent, and the ancestor is success so it only loads component. So nothing preloads the boundary that catches the error. Before 1.170.19, every matched route's chunk loaded all of its component types, so this worked.

const parent = createRoute({
  getParentRoute: () => rootRoute,
  path: '/parent',
  errorComponent: lazyRouteComponent(() => import('./ParentError'), 'ParentError'),
  component: () => <Outlet />,
})

const child = createRoute({
  getParentRoute: () => parent,
  path: '/child',
  loader: () => {
    throw new Error('child loader failed')
  },
  component: () => <p>Child</p>,
})

await router.load()
flushSync(() => createRoot(el).render(<RouterProvider router={router} />))
// 1.170.18: el.textContent === 'Parent errorComponent'
// 1.170.46: el.textContent === '', the error component shows up once the chunk arrives

In the browser this is an empty frame. Under Testing Library (IS_REACT_ACT_ENVIRONMENT), the suspended render inside sync act() is never retried, so a test that awaits router.load() and then renders sees a blank page forever. That's how I found it.

Complete minimal reproducer

https://github.com/loganrosen/tanstack-router-load-lazy-error-component

Steps to Reproduce the Bug
  1. pnpm install && pnpm dev, then open the page. The log at the top shows what the first commit after router.load() contained.
  2. On 1.170.46 it logs first commit: "" and then +312.0ms: "Parent errorComponent".
  3. Set @tanstack/react-router to 1.170.18, pnpm install, reload. It logs first commit: "Parent errorComponent".
  4. pnpm test fails on 1.170.46 and passes on 1.170.18.
Expected behavior

When router.load() resolves, the errorComponent/notFoundComponent of the boundary that will render the error should already be loaded, like it was before 1.170.19. The API docs say load() "resolves when they are all loaded and ready to be rendered".

Screenshots or Videos

No response

Platform
  • Router / Start Version: @tanstack/react-router 1.170.46 (router-core 1.171.39); works on 1.170.18 (router-core 1.171.15)
  • OS: macOS
  • Browser: WebKit (macOS system webview)
  • Bundler: vite
  • Bundler Version: 8.3.5
Additional context

Found while upgrading the router in matrix-authentication-service (element-hq/matrix-authentication-service#6069). We're working around it in our test helper by calling router.loadRouteChunk(route, 'errorComponent') for every match after load(). Possibly related to the loader rewrite in #7926.

The issue was written with help from an AI coding assistant. I ran and checked the reproducer myself.

Vorherrschende Sprache
TypeScript
Sterne
15.3k
Forks
1.9k
Ø Merge
1 T. 5 Std.
Gemergte PRs (30 T.)
46

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TanStack/router

Alle Issues in TanStack/router

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.