router.load() resolves before an ancestor boundary's code-split errorComponent is loaded (regression in 1.170.19)

Abierto
#8,792 1 comentario 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@Sheraff ya está trabajando en esto.

Desde el 23/10/2026.

  • #8793 de @sarankumar1325 — cerrado sin fusionar
  • #8896 de @EnesKartal — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
react, typescript, vite
Área
frontend

Línea de trabajo

Start by tracing router.load() and route chunk loading, especially how an errored child selects an ancestor’s errorComponent; the report points to a regression introduced in 1.170.19 and possibly related to #7926. Use the linked reproducer and its failing test, then compare behavior with 1.170.18. Done means the boundary component is loaded when router.load() resolves and the regression test passes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Which project does this relate to?

Router

Describe the bug

Since 1.170.19, router.load() can resolve before the chunk for the errorComponent that will actually render has loaded. As a result, the first render after load() suspends and is empty.

This happens when a child's loader throws, the child has no errorComponent, and an ancestor's errorComponent is code-split (which autoCodeSplitting does by default). The errored match only loads its own errorComponent, and the ancestor is success so it only loads component. So nothing preloads the boundary that catches the error. Before 1.170.19, every matched route's chunk loaded all of its component types, so this worked.

const parent = createRoute({
  getParentRoute: () => rootRoute,
  path: '/parent',
  errorComponent: lazyRouteComponent(() => import('./ParentError'), 'ParentError'),
  component: () => <Outlet />,
})

const child = createRoute({
  getParentRoute: () => parent,
  path: '/child',
  loader: () => {
    throw new Error('child loader failed')
  },
  component: () => <p>Child</p>,
})

await router.load()
flushSync(() => createRoot(el).render(<RouterProvider router={router} />))
// 1.170.18: el.textContent === 'Parent errorComponent'
// 1.170.46: el.textContent === '', the error component shows up once the chunk arrives

In the browser this is an empty frame. Under Testing Library (IS_REACT_ACT_ENVIRONMENT), the suspended render inside sync act() is never retried, so a test that awaits router.load() and then renders sees a blank page forever. That's how I found it.

Complete minimal reproducer

https://github.com/loganrosen/tanstack-router-load-lazy-error-component

Steps to Reproduce the Bug
  1. pnpm install && pnpm dev, then open the page. The log at the top shows what the first commit after router.load() contained.
  2. On 1.170.46 it logs first commit: "" and then +312.0ms: "Parent errorComponent".
  3. Set @tanstack/react-router to 1.170.18, pnpm install, reload. It logs first commit: "Parent errorComponent".
  4. pnpm test fails on 1.170.46 and passes on 1.170.18.
Expected behavior

When router.load() resolves, the errorComponent/notFoundComponent of the boundary that will render the error should already be loaded, like it was before 1.170.19. The API docs say load() "resolves when they are all loaded and ready to be rendered".

Screenshots or Videos

No response

Platform
  • Router / Start Version: @tanstack/react-router 1.170.46 (router-core 1.171.39); works on 1.170.18 (router-core 1.171.15)
  • OS: macOS
  • Browser: WebKit (macOS system webview)
  • Bundler: vite
  • Bundler Version: 8.3.5
Additional context

Found while upgrading the router in matrix-authentication-service (element-hq/matrix-authentication-service#6069). We're working around it in our test helper by calling router.loadRouteChunk(route, 'errorComponent') for every match after load(). Possibly related to the loader rewrite in #7926.

The issue was written with help from an AI coding assistant. I ran and checked the reproducer myself.

Lenguaje dominante
TypeScript
Estrellas
15.3k
Forks
1.9k
Merge medio
1 d 5 h
PR fusionados (30 d)
46

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TanStack/router

Todos los issues de TanStack/router

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.