constructed-order.json is a stale prefix: 19 constructed histories are unrecorded

Offen
#183 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Anfängerfreundlichkeit
55/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
javascript, node.js
Bereich
testing

Rechercherichtung

Read packages/oracles/oracle-gaps/constructed-order.json and the canary in packages/oracles/tests/gap-report-history-fingerprint.test.ts. Compare the recorded 90 names with the 109 current constructed histories using the fixed seed 20261105, then update the list and canary to catch missing entries. Done means the recorded order includes all histories and the test fails if a history is omitted or inserted before a recorded one.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

packages/oracles/oracle-gaps/constructed-order.json is a stale prefix of the constructed histories of the gap e2e oracle. The canary appends new constructed histories, and never inserts one before a recorded one (packages/oracles/tests/gap-report-history-fingerprint.test.ts) only checks that the recorded list is a prefix of the current list, so the 19 missing names are not caught.

Measured at 11d5aa3d (plus the #182 fix on top, which adds the last one):

  • current constructed histories (fixed seed 20261105 units): 109
  • recorded in constructed-order.json: 90 (a valid prefix)
  • missing: 19

Missing names, in current order:

  • a slow owner's kill and another owner's kill
  • a backstop cut ends the copies ahead of a later kill
  • a kill past the work budget in a later owner
  • a slow kill after a 16 s wait
  • a copy waiting on a timer
  • a copy waiting on an unref'd timer
  • a copy waiting on a pipe it opened
  • a copy beside the runner's pending write
  • a copy beside the runner's pending timer
  • a clocked copy that spins
  • an authored mutant whose owner hangs
  • a stream log lost after its note, then stopped, unsupervised
  • a heavy test that reads the clock after its work
  • a heavy test that reads the clock first
  • a hang in a file whose test does a short read
  • a clocked owner beside a counted one under the work budget
  • a spin after a short async read
  • an authored mutant whose owner spins
  • a later owner's test listed first beside an earlier owner's hang (added by #182)

Proposed fix: record all 109 names in order, and make the canary also require the recorded list to equal the current list for every name that existed on main (or require exact equality on each PR that adds a history). The file is #99's to own once #99 merges; this issue exists so the stale state is visible and tracked rather than left silent.

Vorherrschende Sprache
JavaScript
Sterne
5
Forks
1
Ø Merge
11 Std. 18 Min.
Gemergte PRs (30 T.)
66

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TanStack/oracles

Alle Issues in TanStack/oracles

Ähnliche Issues

Weitere Issues zu JavaScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.