constructed-order.json is a stale prefix: 19 constructed histories are unrecorded

Aperta
#183 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript, node.js
Ambito
testing

Direzione di ricerca

Read packages/oracles/oracle-gaps/constructed-order.json and the canary in packages/oracles/tests/gap-report-history-fingerprint.test.ts. Compare the recorded 90 names with the 109 current constructed histories using the fixed seed 20261105, then update the list and canary to catch missing entries. Done means the recorded order includes all histories and the test fails if a history is omitted or inserted before a recorded one.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

packages/oracles/oracle-gaps/constructed-order.json is a stale prefix of the constructed histories of the gap e2e oracle. The canary appends new constructed histories, and never inserts one before a recorded one (packages/oracles/tests/gap-report-history-fingerprint.test.ts) only checks that the recorded list is a prefix of the current list, so the 19 missing names are not caught.

Measured at 11d5aa3d (plus the #182 fix on top, which adds the last one):

  • current constructed histories (fixed seed 20261105 units): 109
  • recorded in constructed-order.json: 90 (a valid prefix)
  • missing: 19

Missing names, in current order:

  • a slow owner's kill and another owner's kill
  • a backstop cut ends the copies ahead of a later kill
  • a kill past the work budget in a later owner
  • a slow kill after a 16 s wait
  • a copy waiting on a timer
  • a copy waiting on an unref'd timer
  • a copy waiting on a pipe it opened
  • a copy beside the runner's pending write
  • a copy beside the runner's pending timer
  • a clocked copy that spins
  • an authored mutant whose owner hangs
  • a stream log lost after its note, then stopped, unsupervised
  • a heavy test that reads the clock after its work
  • a heavy test that reads the clock first
  • a hang in a file whose test does a short read
  • a clocked owner beside a counted one under the work budget
  • a spin after a short async read
  • an authored mutant whose owner spins
  • a later owner's test listed first beside an earlier owner's hang (added by #182)

Proposed fix: record all 109 names in order, and make the canary also require the recorded list to equal the current list for every name that existed on main (or require exact equality on each PR that adds a history). The file is #99's to own once #99 merges; this issue exists so the stale state is visible and tracked rather than left silent.

Lingua principale
JavaScript
Stelle
5
Fork
1
Merge medio
11h 18m
PR unite (30g)
66

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TanStack/oracles

Tutte le issue di TanStack/oracles

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.