Gap e2e: witnesses owed for session-directory removal (review of #164: F2, F4, F5, F6)

Offen
#168 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
35/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
javascript, node.js
Bereich
devtools, testing

Rechercherichtung

Read packages/oracles/oracle-gaps/paths.mjs and gap-report-oracle.property.test.mjs, then trace the existing gap histories and platform-specific e2e jobs. The issue calls for witnesses for session-directory removal failures, pid reuse, and POSIX unsupervised stops, plus an observed killed state; coordinate ownership with #79. Done means the specified histories judge these gaps and the README explains that an unremovable directory is left.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Follow-ups from the review of #164 (#150's fix). Findings F4, F5 and F6 were not fixed in #164, and neither was a witness for F2(a). Each is a gap in what the gap report's end-to-end oracle judges. None is a known defect.

  • F2(a) and F4: no history makes a session directory's removal fail.
    • removeSession (packages/oracles/oracle-gaps/paths.mjs) catches the failure and leaves the directory for the next run. The catch keeps one done line: without it, a throw after the done line would reach uncaughtException and end the run a second time.
    • A mutant that removes the catch survives every history.
    • Witness owed: a test-only fault that makes the directory unremovable (under G43/R57). The removal then fails, the run ends with one done line and its own exit code, and the next run removes the directory.
    • The README does not say that a directory which cannot be removed is left. The witness should land with that sentence.
  • F2(b): the pid-reuse guard has no witness.
    • removeSession keeps the directory of a pid that a live process runs under. No history reuses a pid.
  • F5: each removal point is judged on only some paths.
    • The supervisor's removal is judged only by abort histories. A SIGINT or SIGTERM stop ends the child through process.exit, and the session's exit listener removes the directory first.
    • The exit listener is judged only on win32 (its hookStops histories), whose e2e jobs are non-blocking. POSIX's one unsupervised history stops at its note, before a session opens.
    • Witness owed: a POSIX unsupervised history that opens a session and is stopped. Today, a stop while the witness spins leaves the test's own child on unsupervised POSIX (C 2026-11-13).
  • F6: whether a stopped run was killed is read from the platform, not observed.
    • The killed field of the stopped observation (gap-report-oracle.property.test.mjs) treats every win32 abort as killed.
    • Once #79 adds a win32 supervisor, a supervised win32 abort must owe the removal of its child's directory. The field must then come from an observation, such as the .child pid beside the started marker, instead of the platform.

Owners:

  • #79 owns F6, and F5's win32 half once its supervisor lands.
  • Isaac, as the follow-up of #164, owns F2(a), F2(b), F4 and F5's POSIX half.

This issue was written by Isaac.

Vorherrschende Sprache
JavaScript
Sterne
5
Forks
1
Ø Merge
11 Std. 18 Min.
Gemergte PRs (30 T.)
66

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TanStack/oracles

Alle Issues in TanStack/oracles

Ähnliche Issues

Weitere Issues zu JavaScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.