Gap e2e: witnesses owed for session-directory removal (review of #164: F2, F4, F5, F6)

未关闭
#168 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
领域
devtools, testing

调研方向

Read packages/oracles/oracle-gaps/paths.mjs and gap-report-oracle.property.test.mjs, then trace the existing gap histories and platform-specific e2e jobs. The issue calls for witnesses for session-directory removal failures, pid reuse, and POSIX unsupervised stops, plus an observed killed state; coordinate ownership with #79. Done means the specified histories judge these gaps and the README explains that an unremovable directory is left.

由索引模型根据 Issue 内容生成。

描述

Follow-ups from the review of #164 (#150's fix). Findings F4, F5 and F6 were not fixed in #164, and neither was a witness for F2(a). Each is a gap in what the gap report's end-to-end oracle judges. None is a known defect.

  • F2(a) and F4: no history makes a session directory's removal fail.
    • removeSession (packages/oracles/oracle-gaps/paths.mjs) catches the failure and leaves the directory for the next run. The catch keeps one done line: without it, a throw after the done line would reach uncaughtException and end the run a second time.
    • A mutant that removes the catch survives every history.
    • Witness owed: a test-only fault that makes the directory unremovable (under G43/R57). The removal then fails, the run ends with one done line and its own exit code, and the next run removes the directory.
    • The README does not say that a directory which cannot be removed is left. The witness should land with that sentence.
  • F2(b): the pid-reuse guard has no witness.
    • removeSession keeps the directory of a pid that a live process runs under. No history reuses a pid.
  • F5: each removal point is judged on only some paths.
    • The supervisor's removal is judged only by abort histories. A SIGINT or SIGTERM stop ends the child through process.exit, and the session's exit listener removes the directory first.
    • The exit listener is judged only on win32 (its hookStops histories), whose e2e jobs are non-blocking. POSIX's one unsupervised history stops at its note, before a session opens.
    • Witness owed: a POSIX unsupervised history that opens a session and is stopped. Today, a stop while the witness spins leaves the test's own child on unsupervised POSIX (C 2026-11-13).
  • F6: whether a stopped run was killed is read from the platform, not observed.
    • The killed field of the stopped observation (gap-report-oracle.property.test.mjs) treats every win32 abort as killed.
    • Once #79 adds a win32 supervisor, a supervised win32 abort must owe the removal of its child's directory. The field must then come from an observation, such as the .child pid beside the started marker, instead of the platform.

Owners:

  • #79 owns F6, and F5's win32 half once its supervisor lands.
  • Isaac, as the follow-up of #164, owns F2(a), F2(b), F4 and F5's POSIX half.

This issue was written by Isaac.

主要语言
JavaScript
星标
5
派生
1
平均合并
11 小时 18 分钟
30 天内合并 PR
66

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TanStack/oracles 的其他 Issue

查看 TanStack/oracles 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。