Multi-tab Electric: a deleted row returns after a peer reset and deploys

Offen
#2,281 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Anfängerfreundlichkeit
38/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
sqlite, typescript
Bereich
databases, testing

Rechercherichtung

Start with packages/browser-db-sqlite-persistence/tests/multi-tab-electric-oracle.test.ts and replay the supplied seed and path using the command in the issue. Trace how the peer reset, deploys, and reserved commit replay affect durable rows and both tabs; record the history in docs/contributing/oracle-coverage.md. Done means the replay passes after the fix, fails on the parent, and a hostile mutant fails.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Summary

The multi-tab Electric oracle found a history where a deleted row returns. After every tab catches up, durable storage and both tabs still contain row 1. The model expects only row 2.

The failure reproduces on origin/main at 4c39add29 and on the head of #2262 (f276b4ad4). The oracle and the behavior it checks came in with #2265. #2262 does not cause it.

Law

A row that the server deletes stays deleted in durable storage and in every tab after all tabs catch up. A peer reset and a later deploy do not bring back a deleted row.

Counterexample

Oracle: packages/browser-db-sqlite-persistence/tests/multi-tab-electric-oracle.test.ts, test keeps reserved commits lawful across generated multi-tab histories (random or replayed), property browser.multi-tab-reserved-history.

{ seed: -1115798760, path: "1:4:3:3:3:3:3:3:3:3:3", endOnFailure: true }
Counterexample: [{"tabCount":2,"steps":[
  {"kind":"server change","key":1,"pick":0},
  {"kind":"advance","tab":1,"pick":0},
  {"kind":"server change","key":1,"pick":0},
  {"kind":"advance","tab":0,"pick":0},
  {"kind":"peer reset"},
  {"kind":"server change","key":1,"pick":0},
  {"kind":"deploy"},
  {"kind":"deploy"},
  {"kind":"server change","key":1,"pick":0},
  {"kind":"server change","key":1,"pick":0}]}]
Shrunk 10 time(s)

Observation after every tab caught up:

actual   {"durableRows":[{"id":1,"label":"one"},{"id":2,"label":"two"}],
          "tabs":[{"tab":"A","status":"ready","rows":[{"id":1,...},{"id":2,...}],"sourceError":true},
                  {"tab":"B","status":"ready","rows":[{"id":1,...},{"id":2,...}],"sourceError":true}]}
expected {"durableRows":[{"id":2,"label":"two"}],
          "tabs":[{"tab":"A","status":"ready","rows":[{"id":2,...}],"sourceError":true},
                  {"tab":"B","status":"ready","rows":[{"id":2,...}],"sourceError":true}]}

The CI job that found it: Test (sqlite-adapters) on #2262, run 40723478437.

Replay

Run this in packages/browser-db-sqlite-persistence:

TANSTACK_DB_ORACLE_PROPERTY=browser.multi-tab-reserved-history \
TANSTACK_DB_ORACLE_SEED=-1115798760 \
TANSTACK_DB_ORACLE_PATH="1:4:3:3:3:3:3:3:3:3:3" \
npx vitest --run tests/multi-tab-electric-oracle.test.ts -t "generated multi-tab"

Related

  • #2267 is a different symptom: a lagging resumed tab goes into error. This issue is a deleted row that returns.
  • The fixed-seed campaign and the pinned storm histories pass. Only the random campaign reached this history.

Next steps

  • Diagnose which step reintroduces row 1: the peer reset, the deploys, or the reserved-commit replay.
  • Record the trace in docs/contributing/oracle-coverage.md under the multi-tab Electric owner until a fix lands.
  • Fix oracle-first: keep this history as a replay, show RED on the parent, GREEN after the fix, and a hostile mutant that fails.
Vorherrschende Sprache
TypeScript
Sterne
4k
Forks
286
Ø Merge
1 T. 8 Std.
Gemergte PRs (30 T.)
105

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TanStack/db

Alle Issues in TanStack/db

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.