Multi-tab Electric: a deleted row returns after a peer reset and deploys
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 5/5
- 預估耗時
- 一週以上
- 新手友好度
- 38/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- sqlite, typescript
研究方向
Start with packages/browser-db-sqlite-persistence/tests/multi-tab-electric-oracle.test.ts and replay the supplied seed and path using the command in the issue. Trace how the peer reset, deploys, and reserved commit replay affect durable rows and both tabs; record the history in docs/contributing/oracle-coverage.md. Done means the replay passes after the fix, fails on the parent, and a hostile mutant fails.
由索引模型根據 Issue 內容生成。
描述
Summary
The multi-tab Electric oracle found a history where a deleted row returns. After every tab catches up, durable storage and both tabs still contain row 1. The model expects only row 2.
The failure reproduces on origin/main at 4c39add29 and on the head of #2262 (f276b4ad4). The oracle and the behavior it checks came in with #2265. #2262 does not cause it.
Law
A row that the server deletes stays deleted in durable storage and in every tab after all tabs catch up. A peer reset and a later deploy do not bring back a deleted row.
Counterexample
Oracle: packages/browser-db-sqlite-persistence/tests/multi-tab-electric-oracle.test.ts, test keeps reserved commits lawful across generated multi-tab histories (random or replayed), property browser.multi-tab-reserved-history.
{ seed: -1115798760, path: "1:4:3:3:3:3:3:3:3:3:3", endOnFailure: true }
Counterexample: [{"tabCount":2,"steps":[
{"kind":"server change","key":1,"pick":0},
{"kind":"advance","tab":1,"pick":0},
{"kind":"server change","key":1,"pick":0},
{"kind":"advance","tab":0,"pick":0},
{"kind":"peer reset"},
{"kind":"server change","key":1,"pick":0},
{"kind":"deploy"},
{"kind":"deploy"},
{"kind":"server change","key":1,"pick":0},
{"kind":"server change","key":1,"pick":0}]}]
Shrunk 10 time(s)
Observation after every tab caught up:
actual {"durableRows":[{"id":1,"label":"one"},{"id":2,"label":"two"}],
"tabs":[{"tab":"A","status":"ready","rows":[{"id":1,...},{"id":2,...}],"sourceError":true},
{"tab":"B","status":"ready","rows":[{"id":1,...},{"id":2,...}],"sourceError":true}]}
expected {"durableRows":[{"id":2,"label":"two"}],
"tabs":[{"tab":"A","status":"ready","rows":[{"id":2,...}],"sourceError":true},
{"tab":"B","status":"ready","rows":[{"id":2,...}],"sourceError":true}]}
The CI job that found it: Test (sqlite-adapters) on #2262, run 40723478437.
Replay
Run this in packages/browser-db-sqlite-persistence:
TANSTACK_DB_ORACLE_PROPERTY=browser.multi-tab-reserved-history \
TANSTACK_DB_ORACLE_SEED=-1115798760 \
TANSTACK_DB_ORACLE_PATH="1:4:3:3:3:3:3:3:3:3:3" \
npx vitest --run tests/multi-tab-electric-oracle.test.ts -t "generated multi-tab"
Related
- #2267 is a different symptom: a lagging resumed tab goes into error. This issue is a deleted row that returns.
- The fixed-seed campaign and the pinned storm histories pass. Only the random campaign reached this history.
Next steps
- Diagnose which step reintroduces row 1: the peer reset, the deploys, or the reserved-commit replay.
- Record the trace in
docs/contributing/oracle-coverage.mdunder the multi-tab Electric owner until a fix lands. - Fix oracle-first: keep this history as a replay, show RED on the parent, GREEN after the fix, and a hostile mutant that fails.
- 主要語言
- TypeScript
- 星號
- 4k
- 分支
- 286
- 平均合併
- 1 天 8 小時
- 30 天內合併 PR
- 105
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
TanStack/db 的其他 Issue
-
extractSimpleComparisons returns value: null when the right side of a comparison isn't a literal未關閉
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
`avg`, `min`, `max` and `sum` treat `null` values as `0`可能已有人在做 @oyobbeb 於 11 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 76/100
維護者通常 1 天內回覆
-
`Collection.currentStateAsChanges` JSDoc examples don’t match `CurrentStateAsChangesOptions`可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉
難度 1/5 1-3 小時 新手友好度 88/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
Two @tanstack/db tests time out under CPU load because a cold module import counts against the 5 s default timeout可能已有人在做 @jp-knj 於 23 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
fb55/htmlparser2#2579 ·
維護者通常 1 天內回覆
-
bug good first issue needs-review
難度 1/5 1-3 小時 新手友好度 83/100
維護者通常 1 天內回覆
-
documentation public
難度 1/5 1-3 小時 新手友好度 68/100
midnightntwrk/umbradb#65 ·
維護者通常 2 天內回覆
-
area/channels kind/bug priority/medium
難度 2/5 1-3 小時 新手友好度 78/100
nanocoai/nanoclaw#4501 · 1 則留言 ·
維護者通常 1 天內回覆
-
needs verification
難度 2/5 1-3 小時 新手友好度 74/100
維護者通常 13 天內回覆