CI perf (coverage tradeoff): Windows-only path bugs reach main because `test (windows-latest, *)` runs only nightly
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 45/100
Rechercherichtung
Start in ci.yml around line 346 where the test job's Windows shards are gated by CI_SCOPE. Read the merge_group trigger and windows-compile-check step to see where to add a Windows cargo test step for socket-patch-core. Done means merge_group runs cargo test -p socket-patch-core --lib on windows-latest while keeping checks ci-ok and clippy unchanged. Validate by triggering a merge_group with a crate change.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Filed by the CI janitor routine. This is a cost vs. coverage tradeoff, so it goes to the CI profiler/implementer and a human. The janitor didn't change CI.
Evidence
On pull_request and merge_group, the test job runs only on Linux, with macOS added on PRs. test (windows-latest, 1|2) runs only when vars.CI_SCOPE == 'full', on the nightly schedule, or on dispatch (ci.yml line 346). On merge_group, Windows gets only windows-compile-check. Windows-only test failures therefore surface after merge, on the nightly run.
Nightly CI (schedule) on main, last 7 days:
| date | run | result | Windows-only failure | fix |
|---|---|---|---|---|
| 10-24 | 40067511756 | ❌ | yarnrc::tests::global_folder_values_read_like_yarn: \${HOME} is read as absolute on Windows |
#1710 (open, green, waiting on review) |
| 10-23 | 39907645034 | ❌ | governing_root::tests::vlt_project_root_governs_unlisted_directories (RUNNER~1 vs \\?\ paths); get_failure_paths::engine_nested_apply_preserves_conflicts_introduced_during_fetch; one test in the user_patches target |
#1686 |
| 10-22 | 39730006970 | ❌ | uv::tests::global_uv_settings_reads_the_user_then_first_system_file (/ vs \) |
#1663 |
| 10-21 | 39551481612 | ✅ | ||
| 10-20 | 39376690526 | ❌ | (Linux, pipenv/uv: not this issue) | #1716 |
Across 3 consecutive nights there were 5 Windows-only test regressions. Each made main red for about a day and needed its own follow-up PR plus another merge-queue trip. All of them were deterministic path-form assertions (separators, 8.3 short names, \\?\ verbatim prefixes), not flakes, so one Windows run of the changed crate's tests before merge would have caught every one.
Options (for the profiler/implementer to cost)
- Run
cargo test -p socket-patch-core --libon Windows in merge_group, next towindows-compile-check. It's the target that failed in 4 of the 5 cases. Its test step took 207–325 s in the failing nightlies, on top of the existing compile-check build. - Use path filters to run the Windows
testshards on merge_group only whencrates/**changes. That is nearly every agent PR, so it would cost about as much as running them always. - Keep the current setup, but add a lint or helper that rejects
/-joinedPathBufexpectations in tests. This is cheaper, but it only covers the separator case.
Please keep the required check names ci-ok and clippy unchanged.
- Vorherrschende Sprache
- Rust
- Sterne
- 8
- Forks
- 2
- Ø Merge
- 19 Std. 9 Min.
- Gemergte PRs (30 T.)
- 641
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus SocketDev/socket-patch
-
agent:triaged bug bughunt pm:npm priority:p3 ux
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
SocketDev/socket-patch#1072 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
-
Nightly Windows test shards fail on temp-path spelling (RUNNER~1 vs canonical \\?\ paths)Evtl. vergeben @mikolalysenko hat das vor 2 Tagen übernommen. Offenagent:claimed agent:triaged ci-janitor priority:p3
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 55/100
SocketDev/socket-patch#1689 · 6 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
-
CI perf (settings): 90-min merge-queue check timeout let one stuck check freeze main for 77 minOffenagent:needs-human agent:triaged ci-perf priority:p3
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 48/100
SocketDev/socket-patch#1670 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
-
agent:triaged ci-janitor priority:p3
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 55/100
SocketDev/socket-patch#1665 · 3 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
-
agent:needs-human agent:triaged ci-janitor priority:p3
Schwierigkeit 4/5 1-2 Tage Anfängerfreundlichkeit 18/100
SocketDev/socket-patch#1660 · 4 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in SocketDev/socket-patch
Ähnliche Issues
-
`mise doctor` Shows Not Installed Lazy Tools as ProblemsEvtl. vergeben @jdx hat das heute übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 67/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
Maintainer antworten meist innerhalb von 1 Tag
-
nn::linear: weight initialization depends on `bias` because the bias is created before the weightEvtl. vergeben @monfortema hat das heute übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
LaurentMazare/tch-rs#1067 ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 64/100
astral-sh/astral-codec#234 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 67/100