CI perf (coverage tradeoff): Windows-only path bugs reach main because `test (windows-latest, *)` runs only nightly
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Start in ci.yml around line 346 where the test job's Windows shards are gated by CI_SCOPE. Read the merge_group trigger and windows-compile-check step to see where to add a Windows cargo test step for socket-patch-core. Done means merge_group runs cargo test -p socket-patch-core --lib on windows-latest while keeping checks ci-ok and clippy unchanged. Validate by triggering a merge_group with a crate change.
由索引模型根據 Issue 內容生成。
描述
Filed by the CI janitor routine. This is a cost vs. coverage tradeoff, so it goes to the CI profiler/implementer and a human. The janitor didn't change CI.
Evidence
On pull_request and merge_group, the test job runs only on Linux, with macOS added on PRs. test (windows-latest, 1|2) runs only when vars.CI_SCOPE == 'full', on the nightly schedule, or on dispatch (ci.yml line 346). On merge_group, Windows gets only windows-compile-check. Windows-only test failures therefore surface after merge, on the nightly run.
Nightly CI (schedule) on main, last 7 days:
| date | run | result | Windows-only failure | fix |
|---|---|---|---|---|
| 10-24 | 40067511756 | ❌ | yarnrc::tests::global_folder_values_read_like_yarn: \${HOME} is read as absolute on Windows |
#1710 (open, green, waiting on review) |
| 10-23 | 39907645034 | ❌ | governing_root::tests::vlt_project_root_governs_unlisted_directories (RUNNER~1 vs \\?\ paths); get_failure_paths::engine_nested_apply_preserves_conflicts_introduced_during_fetch; one test in the user_patches target |
#1686 |
| 10-22 | 39730006970 | ❌ | uv::tests::global_uv_settings_reads_the_user_then_first_system_file (/ vs \) |
#1663 |
| 10-21 | 39551481612 | ✅ | ||
| 10-20 | 39376690526 | ❌ | (Linux, pipenv/uv: not this issue) | #1716 |
Across 3 consecutive nights there were 5 Windows-only test regressions. Each made main red for about a day and needed its own follow-up PR plus another merge-queue trip. All of them were deterministic path-form assertions (separators, 8.3 short names, \\?\ verbatim prefixes), not flakes, so one Windows run of the changed crate's tests before merge would have caught every one.
Options (for the profiler/implementer to cost)
- Run
cargo test -p socket-patch-core --libon Windows in merge_group, next towindows-compile-check. It's the target that failed in 4 of the 5 cases. Its test step took 207–325 s in the failing nightlies, on top of the existing compile-check build. - Use path filters to run the Windows
testshards on merge_group only whencrates/**changes. That is nearly every agent PR, so it would cost about as much as running them always. - Keep the current setup, but add a lint or helper that rejects
/-joinedPathBufexpectations in tests. This is cheaper, but it only covers the separator case.
Please keep the required check names ci-ok and clippy unchanged.
- 主要語言
- Rust
- 星號
- 8
- 分支
- 2
- 平均合併
- 19 小時 31 分鐘
- 30 天內合併 PR
- 686
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
SocketDev/socket-patch 的其他 Issue
-
bug bughunt pm:npm
難度 4/5 3-5 天 新手友好度 53/100
SocketDev/socket-patch#1827 · 1 則留言 ·
維護者通常 1 天內回覆
-
Go apply, apply --check and vex treat a module that is only another module's replace target as built, so the patch is reported applied and attested while go builds the unpatched code可能已有人在做 @mikolalysenko 今天認領。 未關閉agent:claimed agent:triaged bug bughunt pm:go priority:p2
難度 4/5 3-5 天 新手友好度 48/100
SocketDev/socket-patch#1823 · 3 則留言 ·
維護者通常 1 天內回覆
-
Vendored gem mode writes the rewired `gem` line of a CRLF Gemfile with an LF ending, leaving the Gemfile with mixed line endings可能已有人在做 @mikolalysenko 今天認領。 未關閉agent:claimed agent:triaged bug bughunt pm:bundler priority:p1
難度 3/5 1-2 天 新手友好度 25/100
SocketDev/socket-patch#1821 · 3 則留言 ·
維護者通常 1 天內回覆
-
CI perf: workflow_dispatch of CI — Windows-only janitor fixes re-run the full Linux + macOS nightly matrix (~100 min/day, ~30 macOS)可能已有人在做 @mikolalysenko 今天認領。 未關閉agent:claimed agent:triaged ci-perf priority:p3
難度 4/5 3-5 天 新手友好度 1/100
SocketDev/socket-patch#1818 · 3 則留言 ·
維護者通常 1 天內回覆
-
Nightly Windows: 3 Go workspace unit tests fail (Unix-only GOWORK paths)可能已有人在做 @mikolalysenko 於 1 天前認領。 未關閉agent:claimed agent:triaged ci-janitor priority:p3
難度 3/5 1-2 天 新手友好度 35/100
SocketDev/socket-patch#1815 · 2 則留言 ·
維護者通常 1 天內回覆
查看 SocketDev/socket-patch 的全部 Issue
相似的 Issue
-
priority middle
難度 1/5 1 小時以內 新手友好度 62/100
KATO-Hiro/AtCoderClans#12940 ·
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 83/100
維護者通常 1 天內回覆
-
o8 next debug build aborts on Glass to Dark appearance switch (nil identifier messaged before check)未關閉bug
難度 2/5 1-3 小時 新手友好度 78/100
hurttlocker/o8#5112 ·
-
難度 2/5 1-3 小時 新手友好度 79/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆