Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

UK replay gate: a data-limited inert measure blocks certification of every pe-uk release after #2241

Geschlossen
  • Stimmt etwas nicht?
#653 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Ein zugehöriger Pull Request wurde bereits gemerged.

  • #654 von @MaxGhenis — gemerged

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
35/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
python
Bereich
backend-api-design, observability-sre, testing

Rechercherichtung

Start with qualification.py and the scorecard replay path for autumn_budget_2024__sdlt_additional_dwelling_surcharge_2pp, using the cited replay-state receipts as the initial reproduction. Trace how integrity failures and budget_inputs evidence are recorded, then locate the policy configuration for d1344-replay-regressions-v2. Done means the specified reviewed, code/event/measure/year-matched exceptions are narrowly applied only while every required input is missing, with matched regressions remaining review items rather than passes.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

No policyengine-uk release after policyengine-uk#2241 can be certified, even by a named reviewer.

What happens. #2241 (merged 15 October) correctly stops charging property stocks as purchases. SDLT higher rates now apply to additional_residential_property_purchased, which no uk-data release provides yet (the imputation is policyengine-uk-data#573). So on candidates 2.134.6 and 2.134.7 (with uk-data 1.58.2), the scorecard replay of autumn_budget_2024__sdlt_additional_dwelling_surcharge_2pp is inert for 2025–2029: base £2.50bn in 2029 under the old bug, head £0. Those 5 construction_inert rows are the receipts' only integrity failures (replay-state receipts b989d471…, 71e40ada…). The same attempts' budget_inputs gate reports the input as newly missing.

Why nothing can qualify. qualification.py fails every receipt whose integrity failed. Under the d1344 rule, a failure can't be accepted on review, and a known gap never excuses a £0 total against a material base value.

Proposed change. Add narrow, receipt-recorded data-limited exceptions:

  • a reviewed registry entry matched by code, event, measure key and year;
  • it applies only while the same attempt's budget_inputs evidence reports every required input missing, so it expires once the data provides them;
  • matched regressions become review items, never a pass;
  • the policy moves to d1344-replay-regressions-v2.
Vorherrschende Sprache
Python
Sterne
8
Forks
10
Ø Merge
1 T. 2 Std.
Gemergte PRs (30 T.)
52

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus PolicyEngine/policyengine.py

Alle Issues in PolicyEngine/policyengine.py

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.