Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

UK replay gate: a data-limited inert measure blocks certification of every pe-uk release after #2241

Chiusa
  • Qualcosa non va?
#653 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Una pull request collegata è già stata integrata.

  • #654 di @MaxGhenis — integrata

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
backend-api-design, observability-sre, testing

Direzione di ricerca

Start with qualification.py and the scorecard replay path for autumn_budget_2024__sdlt_additional_dwelling_surcharge_2pp, using the cited replay-state receipts as the initial reproduction. Trace how integrity failures and budget_inputs evidence are recorded, then locate the policy configuration for d1344-replay-regressions-v2. Done means the specified reviewed, code/event/measure/year-matched exceptions are narrowly applied only while every required input is missing, with matched regressions remaining review items rather than passes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

No policyengine-uk release after policyengine-uk#2241 can be certified, even by a named reviewer.

What happens. #2241 (merged 15 October) correctly stops charging property stocks as purchases. SDLT higher rates now apply to additional_residential_property_purchased, which no uk-data release provides yet (the imputation is policyengine-uk-data#573). So on candidates 2.134.6 and 2.134.7 (with uk-data 1.58.2), the scorecard replay of autumn_budget_2024__sdlt_additional_dwelling_surcharge_2pp is inert for 2025–2029: base £2.50bn in 2029 under the old bug, head £0. Those 5 construction_inert rows are the receipts' only integrity failures (replay-state receipts b989d471…, 71e40ada…). The same attempts' budget_inputs gate reports the input as newly missing.

Why nothing can qualify. qualification.py fails every receipt whose integrity failed. Under the d1344 rule, a failure can't be accepted on review, and a known gap never excuses a £0 total against a material base value.

Proposed change. Add narrow, receipt-recorded data-limited exceptions:

  • a reviewed registry entry matched by code, event, measure key and year;
  • it applies only while the same attempt's budget_inputs evidence reports every required input missing, so it expires once the data provides them;
  • matched regressions become review items, never a pass;
  • the policy moves to d1344-replay-regressions-v2.
Lingua principale
Python
Stelle
8
Fork
10
Merge medio
23h 16m
PR unite (30g)
49

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di PolicyEngine/policyengine.py

Tutte le issue di PolicyEngine/policyengine.py

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.