[BUG][JAVA][SPRING] Collection request-body validation skipped with useSpringBuiltInValidation=true after 7.25.0

Offen
#25,734 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@Inf1mum arbeitet bereits daran.

Seit 18.11.2026.

  • #25741 von @Inf1mum — offen

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
35/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
java, spring
Bereich
api, backend

Rechercherichtung

Start with modules/openapi-generator/src/main/resources/JavaSpring/bodyParams.mustache and compare the v7.25.0 and v7.26.0 versions linked in the issue. Then inspect the Spring generator tests that cover request body validation and reproduce the described collection request with useSpringBuiltInValidation=true. Done means the generated interface preserves validation and the invalid item returns HTTP 400 before the controller runs; coordinate with the already open PR #25741.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Issue: Bug

Description

After upgrading openapi-generator-maven-plugin from 7.25.0 to 7.27.0, an existing Spring MVC endpoint accepting a list of DTOs accepts invalid collection elements instead of returning HTTP 400.

We use useSpringBuiltInValidation=true, so the generated interface does not have class-level @Validated.

The generated request parameter changes from:

@Valid @RequestBody List<@Valid Item> items

to:

@RequestBody List<@Valid Item> items

The DTO constraints are unchanged.

Expected: Invalid collection elements are rejected with HTTP 400 before the controller implementation executes.

Actual: Invalid collection elements reach the controller, and the endpoint returns HTTP 204.

With 7.25.0, the request is rejected with HandlerMethodValidationException.

Versions

  • Previously working: 7.25.0
  • Runtime failure observed: 7.27.0
  • The relevant template change is already present in 7.26.0, but that version has not been separately runtime-tested.
  • Spring Boot: 3.5.16
  • Java: 21

Template comparison:

https://github.com/OpenAPITools/openapi-generator/blob/v7.25.0/modules/openapi-generator/src/main/resources/JavaSpring/bodyParams.mustache

https://github.com/OpenAPITools/openapi-generator/blob/v7.26.0/modules/openapi-generator/src/main/resources/JavaSpring/bodyParams.mustache

Generator configuration

<generatorName>spring</generatorName>
<library>spring-boot</library>
<generateApis>true</generateApis>
<configOptions>
  <useSpringBoot3>true</useSpringBoot3>
  <useJakartaEe>true</useJakartaEe>
  <interfaceOnly>true</interfaceOnly>
  <skipDefaultInterface>true</skipDefaultInterface>
  <useResponseEntity>false</useResponseEntity>
  <useSpringBuiltInValidation>true</useSpringBuiltInValidation>
</configOptions>

Illustrative OpenAPI specification

The regression was observed in an existing application. This generic specification illustrates the affected request shape; this standalone example has not yet been executed.

openapi: 3.0.3
info:
  title: Collection validation example
  version: 1.0.0
paths:
  /items:
    post:
      operationId: updateItems
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: array
              items:
                $ref: '#/components/schemas/Item'
      responses:
        '204':
          description: Accepted
components:
  schemas:
    Item:
      type: object
      properties:
        name:
          type: string
          maxLength: 3

Implement the generated interface in a @RestController, without adding class-level @Validated, and submit:

POST /items
Content-Type: application/json

[{"name":"too long"}]

The invalid name should cause HTTP 400 rather than reaching the controller.

Related upstream change

This appears related to the removal of container-level @Valid in:

https://github.com/OpenAPITools/openapi-generator/pull/24176

The author's runtime verification uses a controller annotated with class-level @Validated:

https://github.com/OpenAPITools/openapi-generator/pull/24176#issuecomment-4859610681

However, useSpringBuiltInValidation=true intentionally suppresses that annotation and uses Spring MVC's built-in validation. Therefore, that verification does not cover this configuration.

Could the generator preserve collection request-body validation with useSpringBuiltInValidation=true, or document a supported migration for this configuration?

Vorherrschende Sprache
Java
Sterne
26.9k
Forks
7.8k
Ø Merge
2 T. 23 Min.
Gemergte PRs (30 T.)
177

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus OpenAPITools/openapi-generator

Alle Issues in OpenAPITools/openapi-generator

Ähnliche Issues

Weitere Issues zu Java

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.