[BUG][JAVA][SPRING] Collection request-body validation skipped with useSpringBuiltInValidation=true after 7.25.0

Aperta
#25,734 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@Inf1mum ci sta già lavorando.

Dal 18/11/2026.

  • #25741 di @Inf1mum — aperta

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
java, spring
Ambito
api, backend

Direzione di ricerca

Start with modules/openapi-generator/src/main/resources/JavaSpring/bodyParams.mustache and compare the v7.25.0 and v7.26.0 versions linked in the issue. Then inspect the Spring generator tests that cover request body validation and reproduce the described collection request with useSpringBuiltInValidation=true. Done means the generated interface preserves validation and the invalid item returns HTTP 400 before the controller runs; coordinate with the already open PR #25741.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Issue: Bug

Description

After upgrading openapi-generator-maven-plugin from 7.25.0 to 7.27.0, an existing Spring MVC endpoint accepting a list of DTOs accepts invalid collection elements instead of returning HTTP 400.

We use useSpringBuiltInValidation=true, so the generated interface does not have class-level @Validated.

The generated request parameter changes from:

@Valid @RequestBody List<@Valid Item> items

to:

@RequestBody List<@Valid Item> items

The DTO constraints are unchanged.

Expected: Invalid collection elements are rejected with HTTP 400 before the controller implementation executes.

Actual: Invalid collection elements reach the controller, and the endpoint returns HTTP 204.

With 7.25.0, the request is rejected with HandlerMethodValidationException.

Versions

  • Previously working: 7.25.0
  • Runtime failure observed: 7.27.0
  • The relevant template change is already present in 7.26.0, but that version has not been separately runtime-tested.
  • Spring Boot: 3.5.16
  • Java: 21

Template comparison:

https://github.com/OpenAPITools/openapi-generator/blob/v7.25.0/modules/openapi-generator/src/main/resources/JavaSpring/bodyParams.mustache

https://github.com/OpenAPITools/openapi-generator/blob/v7.26.0/modules/openapi-generator/src/main/resources/JavaSpring/bodyParams.mustache

Generator configuration

<generatorName>spring</generatorName>
<library>spring-boot</library>
<generateApis>true</generateApis>
<configOptions>
  <useSpringBoot3>true</useSpringBoot3>
  <useJakartaEe>true</useJakartaEe>
  <interfaceOnly>true</interfaceOnly>
  <skipDefaultInterface>true</skipDefaultInterface>
  <useResponseEntity>false</useResponseEntity>
  <useSpringBuiltInValidation>true</useSpringBuiltInValidation>
</configOptions>

Illustrative OpenAPI specification

The regression was observed in an existing application. This generic specification illustrates the affected request shape; this standalone example has not yet been executed.

openapi: 3.0.3
info:
  title: Collection validation example
  version: 1.0.0
paths:
  /items:
    post:
      operationId: updateItems
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: array
              items:
                $ref: '#/components/schemas/Item'
      responses:
        '204':
          description: Accepted
components:
  schemas:
    Item:
      type: object
      properties:
        name:
          type: string
          maxLength: 3

Implement the generated interface in a @RestController, without adding class-level @Validated, and submit:

POST /items
Content-Type: application/json

[{"name":"too long"}]

The invalid name should cause HTTP 400 rather than reaching the controller.

Related upstream change

This appears related to the removal of container-level @Valid in:

https://github.com/OpenAPITools/openapi-generator/pull/24176

The author's runtime verification uses a controller annotated with class-level @Validated:

https://github.com/OpenAPITools/openapi-generator/pull/24176#issuecomment-4859610681

However, useSpringBuiltInValidation=true intentionally suppresses that annotation and uses Spring MVC's built-in validation. Therefore, that verification does not cover this configuration.

Could the generator preserve collection request-body validation with useSpringBuiltInValidation=true, or document a supported migration for this configuration?

Lingua principale
Java
Stelle
26.9k
Fork
7.8k
Merge medio
2g 23m
PR unite (30g)
177

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di OpenAPITools/openapi-generator

Tutte le issue di OpenAPITools/openapi-generator

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.