[BUG][KOTLIN] kotlinx_serialization: a string-or-number anyOf/oneOf with number mapped to kotlin.Long/kotlin.Double still doesn't compile in 7.27.0

Offen
  • Stimmt etwas nicht?
#25,587 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@cpruijsen arbeitet bereits daran.

Seit 12.11.2026.

  • #25645 von @cpruijsen — offen

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
76/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
java, kotlin
Bereich
backend, tooling

Rechercherichtung

Read kotlin-client/anyof_class.mustache and oneof_class.mustache, focusing on the serialize() branches for primitive numeric types and how type mappings affect their flags. Reproduce the failure with the Kotlin generator and kotlinx_serialization options in the issue, then run the generated client’s compileKotlin task. Done when generated string-or-number anyOf and oneOf models compile and encode every numeric branch as a JSON number.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

[!NOTE]
🤖 Claude Opus 5.5 opening this issue on behalf of Will

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
Description

Follow-up to #25452, which #25472 closed. With the kotlin generator, serializationLibrary=kotlinx_serialization and generateOneOfAnyOfWrappers=true, a string-or-number anyOf/oneOf still doesn't compile on 7.27.0 when the number is mapped to a Kotlin type (--type-mappings=integer=kotlin.Long,number=kotlin.Double). Mapping integer to Long is common because epoch milliseconds overflow an Int.

when (value) {
    is AnyOfValue.StringValue -> jsonEncoder.encodeString(value.value)
}

when (value) {
    is AnyOfInteger.StringValue -> jsonEncoder.encodeString(value.value)
    is AnyOfInteger.LongValue -> jsonEncoder.encodeInt(value.value)
}

e: build/generated/src/main/kotlin/repro/models/AnyOfInteger.kt:67:64 Argument type mismatch: actual type is 'Long', but 'Int' was expected.
e: build/generated/src/main/kotlin/repro/models/AnyOfValue.kt:65:9 'when' expression must be exhaustive. Add the 'is DoubleValue' branch or an 'else' branch.
e: build/generated/src/main/kotlin/repro/models/OneOfInteger.kt:66:64 Argument type mismatch: actual type is 'Long', but 'Int' was expected.
e: build/generated/src/main/kotlin/repro/models/OneOfValue.kt:64:9 'when' expression must be exhaustive. Add the 'is DoubleValue' branch or an 'else' branch.

In kotlin-client/anyof_class.mustache and oneof_class.mustache, #25472 added an {{#isNumber}} case under {{^isPrimitiveType}} (the unmapped BigDecimal). A mapped kotlin.Double is a primitive, so it reaches the {{#isPrimitiveType}} cases, where a number is written only under {{#isDouble}} or {{#isFloat}}, and an unformatted number sets neither. An unformatted integer sets isInteger but not isLong, so it's written with encodeInt even when mapped to kotlin.Long.

openapi-generator version

7.27.0 (CLI from Maven Central). Not a regression: 7.26.0 fails the same way for these mappings.

OpenAPI declaration file content or url
openapi: 3.0.3
info:
  title: String or number
  version: 1.0.0
paths:
  /any:
    get:
      operationId: getAnyOf
      responses:
        "200":
          description: A string or a number
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/AnyOfValue"
components:
  schemas:
    AnyOfValue:
      anyOf:
        - type: string
        - type: number
    OneOfValue:
      oneOf:
        - type: string
        - type: number
    AnyOfInteger:
      anyOf:
        - type: string
        - type: integer
    OneOfInteger:
      oneOf:
        - type: string
        - type: integer
Generation Details
java -jar openapi-generator-cli-7.27.0.jar generate -g kotlin --library jvm-retrofit2 -i openapi.yaml -o generated \
  --package-name repro \
  --additional-properties=serializationLibrary=kotlinx_serialization,useCoroutines=true,generateOneOfAnyOfWrappers=true \
  --type-mappings=integer=kotlin.Long,number=kotlin.Double
Steps to reproduce

https://github.com/ceolinwill/openapi-generator-kotlin-anyof-number-repro runs the 7.27.0 CLI with those options and compiles the client:

./gradlew compileKotlin

It fails with the four errors above. Expected: the client compiles, and every number branch is written as a JSON number.

Related issues/PRs

#25452, #25472

Suggest a fix

Write every numeric primitive branch the same way, with one case in place of the isInteger/isLong/isNumber cases under {{#isPrimitiveType}} in serialize():

{{#isNumeric}}
is {{classname}}.{{#fnToValueClassName}}{{{dataType}}}{{/fnToValueClassName}} -> jsonEncoder.encodeJsonElement(JsonPrimitive(value.value))
{{/isNumeric}}

With that, unions of string with integer, int64, number, double and float compile and round-trip a number, with and without the mappings. We override anyof_class.mustache in our project with the narrower equivalent (encodeLong for the integer case and an encodeDouble case for a number without isDouble/isFloat) until a release fixes it.

Vorherrschende Sprache
Java
Sterne
26.9k
Forks
7.8k
Ø Merge
2 T. 10 Std.
Gemergte PRs (30 T.)
180

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus OpenAPITools/openapi-generator

Alle Issues in OpenAPITools/openapi-generator

Ähnliche Issues

Weitere Issues zu Java

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.