[BUG][KOTLIN] kotlinx_serialization: a string-or-number anyOf/oneOf with number mapped to kotlin.Long/kotlin.Double still doesn't compile in 7.27.0
Mantenedores costumam responder em até 1 dia
Avaliação
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Facilidade para iniciantes
- 76/100
Direção de pesquisa
Read kotlin-client/anyof_class.mustache and oneof_class.mustache, focusing on the serialize() branches for primitive numeric types and how type mappings affect their flags. Reproduce the failure with the Kotlin generator and kotlinx_serialization options in the issue, then run the generated client’s compileKotlin task. Done when generated string-or-number anyOf and oneOf models compile and encode every numeric branch as a JSON number.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
[!NOTE]
🤖 Claude Opus 5.5 opening this issue on behalf of Will
Bug Report Checklist
- Have you provided a full/minimal spec to reproduce the issue?
- Have you validated the input using an OpenAPI validator?
- Have you tested with the latest master to confirm the issue still exists?
- Have you searched for related issues/PRs?
- What's the actual output vs expected output?
Description
Follow-up to #25452, which #25472 closed. With the kotlin generator, serializationLibrary=kotlinx_serialization and generateOneOfAnyOfWrappers=true, a string-or-number anyOf/oneOf still doesn't compile on 7.27.0 when the number is mapped to a Kotlin type (--type-mappings=integer=kotlin.Long,number=kotlin.Double). Mapping integer to Long is common because epoch milliseconds overflow an Int.
when (value) {
is AnyOfValue.StringValue -> jsonEncoder.encodeString(value.value)
}
when (value) {
is AnyOfInteger.StringValue -> jsonEncoder.encodeString(value.value)
is AnyOfInteger.LongValue -> jsonEncoder.encodeInt(value.value)
}
e: build/generated/src/main/kotlin/repro/models/AnyOfInteger.kt:67:64 Argument type mismatch: actual type is 'Long', but 'Int' was expected.
e: build/generated/src/main/kotlin/repro/models/AnyOfValue.kt:65:9 'when' expression must be exhaustive. Add the 'is DoubleValue' branch or an 'else' branch.
e: build/generated/src/main/kotlin/repro/models/OneOfInteger.kt:66:64 Argument type mismatch: actual type is 'Long', but 'Int' was expected.
e: build/generated/src/main/kotlin/repro/models/OneOfValue.kt:64:9 'when' expression must be exhaustive. Add the 'is DoubleValue' branch or an 'else' branch.
In kotlin-client/anyof_class.mustache and oneof_class.mustache, #25472 added an {{#isNumber}} case under {{^isPrimitiveType}} (the unmapped BigDecimal). A mapped kotlin.Double is a primitive, so it reaches the {{#isPrimitiveType}} cases, where a number is written only under {{#isDouble}} or {{#isFloat}}, and an unformatted number sets neither. An unformatted integer sets isInteger but not isLong, so it's written with encodeInt even when mapped to kotlin.Long.
openapi-generator version
7.27.0 (CLI from Maven Central). Not a regression: 7.26.0 fails the same way for these mappings.
OpenAPI declaration file content or url
openapi: 3.0.3
info:
title: String or number
version: 1.0.0
paths:
/any:
get:
operationId: getAnyOf
responses:
"200":
description: A string or a number
content:
application/json:
schema:
$ref: "#/components/schemas/AnyOfValue"
components:
schemas:
AnyOfValue:
anyOf:
- type: string
- type: number
OneOfValue:
oneOf:
- type: string
- type: number
AnyOfInteger:
anyOf:
- type: string
- type: integer
OneOfInteger:
oneOf:
- type: string
- type: integer
Generation Details
java -jar openapi-generator-cli-7.27.0.jar generate -g kotlin --library jvm-retrofit2 -i openapi.yaml -o generated \
--package-name repro \
--additional-properties=serializationLibrary=kotlinx_serialization,useCoroutines=true,generateOneOfAnyOfWrappers=true \
--type-mappings=integer=kotlin.Long,number=kotlin.Double
Steps to reproduce
https://github.com/ceolinwill/openapi-generator-kotlin-anyof-number-repro runs the 7.27.0 CLI with those options and compiles the client:
./gradlew compileKotlin
It fails with the four errors above. Expected: the client compiles, and every number branch is written as a JSON number.
Related issues/PRs
#25452, #25472
Suggest a fix
Write every numeric primitive branch the same way, with one case in place of the isInteger/isLong/isNumber cases under {{#isPrimitiveType}} in serialize():
{{#isNumeric}}
is {{classname}}.{{#fnToValueClassName}}{{{dataType}}}{{/fnToValueClassName}} -> jsonEncoder.encodeJsonElement(JsonPrimitive(value.value))
{{/isNumeric}}
With that, unions of string with integer, int64, number, double and float compile and round-trip a number, with and without the mappings. We override anyof_class.mustache in our project with the narrower equivalent (encodeLong for the integer case and an encodeDouble case for a number without isDouble/isFloat) until a release fixes it.
- Linguagem predominante
- Java
- Estrelas
- 26.9k
- Forks
- 7.8k
- Merge médio
- 2d 10h
- PRs com merge (30d)
- 180
Preparar o ambiente
Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.
- Inclui um Dockerfile ou arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de OpenAPITools/openapi-generator
-
Issue: Bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 80/100
OpenAPITools/openapi-generator#25643 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
OpenAPITools/openapi-generator#25640 ·
Mantenedores costumam responder em até 1 dia
-
[BUG][JAVA] Deprecated properties only get @Deprecated on the getter (base, feign, native, microprofile)Talvez já em andamento @Inf1mum assumiu há 2 dias. AbertaIssue: Bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
OpenAPITools/openapi-generator#25567 ·
Mantenedores costumam responder em até 1 dia
-
[BUG][KOTLIN-SERVER] typeInfoAnnotation.mustache uses As.PROPERTY → discriminator property serialized twiceTalvez já em andamento @Inf1mum assumiu há 9 dias. AbertaIssue: Bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 62/100
OpenAPITools/openapi-generator#25524 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
[REQ][JAVA][resteasy] Support for Jackson 3 / useJackson3Talvez já em andamento Um pull request vinculado a esta issue está aberto ou já foi mesclado. AbertaEnhancement: Feature
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
OpenAPITools/openapi-generator#25364 ·
Mantenedores costumam responder em até 1 dia
Todas as issues de OpenAPITools/openapi-generator
Issues semelhantes
-
bug emitter:client:csharp
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 84/100
microsoft/typespec#12572 · 1 comentário · 1 reação ·
Mantenedores costumam responder em até 1 dia
-
GCC 15.2: -Wcast-qual warning - cast discards const qualifier from pointer target type (H5trace.c)Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 73/100
Mantenedores costumam responder em até 1 dia
-
[Bug] RemotingHelper.connect swaps the socket send and receive buffer configurationTalvez já em andamento @amalsaidov assumiu hoje. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
Mantenedores costumam responder em até 1 dia
-
needs-area-label
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
Mantenedores costumam responder em até 2 dias
-
area/ai area/backend component/zeebe kind/task
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
Mantenedores costumam responder em até 1 dia