[BUG][PHP] Nullable model reference in an array or map loses its namespace separators

Offen
  • Stimmt etwas nicht?
#25,574 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
65/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
java, php
Bereich
backend-api-design

Rechercherichtung

Start by reading AbstractPhpCodegen.getTypeDeclaration(Schema) and compare how it handles a plain $ref with nullable oneOf, anyOf, and allOf references. Reproduce with the supplied OpenAPI spec using the PHP generator, then inspect lib/Model/Thing.php and the deserialization error. Done when the generated type includes \OpenAPI\Client\Model\Inner and both object and null map values deserialize.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
Description

When an array item or a map value is a nullable reference to a model, the PHP client writes its type in $openAPITypes without namespace separators: array<string,\OpenAPIClientModelInner> or \OpenAPIClientModelInner[] instead of \OpenAPI\Client\Model\Inner, so ObjectSerializer::deserialize fails on every non-null value.

It happens with oneOf: [$ref, {type: "null"}], with the same anyOf, and with OpenAPI 3.0 allOf: [$ref] plus nullable: true. The type is correct for the same nullable reference as a plain property, for a plain $ref map value, and for a map of oneOf two models.

openapi-generator version

7.27.0, and master at d15b0164 (7.28.0-SNAPSHOT).

OpenAPI declaration file content or url
openapi: 3.1.0
info: {title: t, version: "1"}
paths:
  /things:
    get:
      responses: {"200": {description: ok, content: {application/json: {schema: {$ref: "#/components/schemas/Thing"}}}}}
components:
  schemas:
    Inner: {type: object, properties: {name: {type: string}}}
    Thing: {type: object, properties: {deps: {type: object, additionalProperties: {oneOf: [{$ref: "#/components/schemas/Inner"}, {type: "null"}]}}}}

validate reports no issues.

Generation Details
java -jar openapi-generator-cli.jar generate -g php -i spec.yaml -o out
Steps to reproduce

lib/Model/Thing.php has 'deps' => 'array<string,\OpenAPIClientModelInner>'. After composer install:

ObjectSerializer::deserialize(json_decode('{"deps": {"a": {"name": "x"}}}'), '\OpenAPI\Client\Model\Thing');
// Error: Class "\OpenAPIClientModelInner" not found

{"deps": {"a": null}} decodes. Expected: 'array<string,\OpenAPI\Client\Model\Inner>', and both values decode.

Related issues/PRs

#2011 is the same kind of wrong type string in $openAPITypes, from oneOf over two models.

Suggest a fix

AbstractPhpCodegen.getTypeDeclaration(Schema) prefixes \ + modelPackage only when the inner schema is a plain $ref. A nullable oneOf/anyOf/allOf around the ref falls through to super.getTypeDeclaration, and the separators are lost somewhere on that path. Unwrapping the nullable wrapper to its $ref before that check might fix it; I haven't tested a patch.

Vorherrschende Sprache
Java
Sterne
26.9k
Forks
7.8k
Ø Merge
2 T. 10 Std.
Gemergte PRs (30 T.)
180

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus OpenAPITools/openapi-generator

Alle Issues in OpenAPITools/openapi-generator

Ähnliche Issues

Weitere Issues zu Java

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.