[BUG][PHP] Nullable model reference in an array or map loses its namespace separators

Aberta
  • Algo errado?
#25,574 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
65/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
java, php
Domínio
backend-api-design

Direção de pesquisa

Start by reading AbstractPhpCodegen.getTypeDeclaration(Schema) and compare how it handles a plain $ref with nullable oneOf, anyOf, and allOf references. Reproduce with the supplied OpenAPI spec using the PHP generator, then inspect lib/Model/Thing.php and the deserialization error. Done when the generated type includes \OpenAPI\Client\Model\Inner and both object and null map values deserialize.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
Description

When an array item or a map value is a nullable reference to a model, the PHP client writes its type in $openAPITypes without namespace separators: array<string,\OpenAPIClientModelInner> or \OpenAPIClientModelInner[] instead of \OpenAPI\Client\Model\Inner, so ObjectSerializer::deserialize fails on every non-null value.

It happens with oneOf: [$ref, {type: "null"}], with the same anyOf, and with OpenAPI 3.0 allOf: [$ref] plus nullable: true. The type is correct for the same nullable reference as a plain property, for a plain $ref map value, and for a map of oneOf two models.

openapi-generator version

7.27.0, and master at d15b0164 (7.28.0-SNAPSHOT).

OpenAPI declaration file content or url
openapi: 3.1.0
info: {title: t, version: "1"}
paths:
  /things:
    get:
      responses: {"200": {description: ok, content: {application/json: {schema: {$ref: "#/components/schemas/Thing"}}}}}
components:
  schemas:
    Inner: {type: object, properties: {name: {type: string}}}
    Thing: {type: object, properties: {deps: {type: object, additionalProperties: {oneOf: [{$ref: "#/components/schemas/Inner"}, {type: "null"}]}}}}

validate reports no issues.

Generation Details
java -jar openapi-generator-cli.jar generate -g php -i spec.yaml -o out
Steps to reproduce

lib/Model/Thing.php has 'deps' => 'array<string,\OpenAPIClientModelInner>'. After composer install:

ObjectSerializer::deserialize(json_decode('{"deps": {"a": {"name": "x"}}}'), '\OpenAPI\Client\Model\Thing');
// Error: Class "\OpenAPIClientModelInner" not found

{"deps": {"a": null}} decodes. Expected: 'array<string,\OpenAPI\Client\Model\Inner>', and both values decode.

Related issues/PRs

#2011 is the same kind of wrong type string in $openAPITypes, from oneOf over two models.

Suggest a fix

AbstractPhpCodegen.getTypeDeclaration(Schema) prefixes \ + modelPackage only when the inner schema is a plain $ref. A nullable oneOf/anyOf/allOf around the ref falls through to super.getTypeDeclaration, and the separators are lost somewhere on that path. Unwrapping the nullable wrapper to its $ref before that check might fix it; I haven't tested a patch.

Linguagem predominante
Java
Estrelas
26.9k
Forks
7.8k
Merge médio
2d 10h
PRs com merge (30d)
180

Preparar o ambiente

Abrir no Codespaces

Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de OpenAPITools/openapi-generator

Todas as issues de OpenAPITools/openapi-generator

Issues semelhantes

Mais issues de Java

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.