ns embed ios: finish the host metadata setup (duplicate -sectcreate flags, missing metadata file, hardcoded arch)

Offen
  • Stimmt etwas nicht?
#6,168 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
50/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
mobile-dev

Rechercherichtung

The work centers on lib/services/ios-project-service.ts lines 738-829. Make the -sectcreate flag addition idempotent, implement the missing metadata file delivery (uncomment or replace the build phase), replace the hardcoded metadata-arm64.bin with architecture/SDK-aware naming, and surface errors from the silent try/catch. Review prepare-native-platform-service.ts for the embed flow.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

feature-pending-triage
Is your feature request related to a problem? Please describe.

ns embed ios (added in #5803) leaves the host project's metadata setup half-finished. This issue tracks the follow-ups.

Context: NativeScript/ios#488 changes the runtime so that, when Config.MetadataPtr is nil, it reads the __DATA,__TNSMetadata section of the host executable. Until that lands, the section ns embed ios links into the host is never read (embedded apps run on the default metadata baked into NativeScript.framework), which is why these problems have gone unnoticed. Once it lands, the section becomes the metadata the embedded app actually runs on.

The relevant block is in lib/services/ios-project-service.ts.

1. The linker flag is appended on every run (bug)

project.addToOtherLinkerFlags('-sectcreate __DATA __TNSMetadata "<project>/metadata-arm64.bin"') runs on every ns embed ios: embed forces prepareProject each time (prepare-native-platform-service.ts), and addToOtherLinkerFlags in nativescript-dev-xcode pushes without checking for an existing entry. The host's OTHER_LDFLAGS gains one more copy per run.

ld accepts a repeated -sectcreate for the same segment/section and concatenates the files (checked with a two-flag test link: a 17-byte file produced a 34-byte section). So every re-run adds another full copy of the metadata (roughly 9–12 MB each) to the host executable. The app still works, because the runtime reads from the start of the section.

2. Nothing delivers the metadata file

The flag points at <hostProject>/<projectName>/metadata-arm64.bin, but nothing creates that file. The "Copy Metadata (DEBUG)" build phase is commented out and step 2 ("Ensure metadata is copied as a file") is a // TODO. ns embed is a prepare, so the metadata generator never runs. Users have to build the NativeScript project separately and copy the file by hand (as the ns-embed-example README describes), and the host fails to link if it is missing.

3. The architecture and SDK are hardcoded

The flag always names metadata-arm64.bin, and the documented manual step copies the simulator build's file, so device builds link metadata generated against the simulator SDK. The app template uses metadata-$(CURRENT_ARCH).bin from the configuration build dir.

4. Failures in this block are silent

The whole host-project setup is wrapped in a try/catch that only logs at trace level ("Error adding NativeScript group to host project"), so a failure leaves the host partially configured with no visible error.

Describe the solution you'd like
  • Make adding the -sectcreate flag idempotent (skip or replace an existing entry), and clean up duplicates left by earlier runs.
  • Have ns embed ios put the metadata in place, e.g. a build phase in the host that copies it from the NativeScript project's build output (what the commented-out phase sketched).
  • Reference the metadata per architecture and SDK instead of a fixed metadata-arm64.bin.
  • Surface errors from the host-project setup instead of logging them at trace level.
Describe alternatives you've considered

For the metadata file: instead of copying the NativeScript project's metadata, run the metadata generator against the host project's own build settings (the nsld.sh mechanism the app template uses). That would also cover native classes that exist only in the host, which the copied metadata does not describe, but it is a larger change. Copying is a reasonable first step.

Having the host pass Config.MetadataPtr explicitly is no longer needed once NativeScript/ios#488 is in: the runtime finds the host executable's section itself, so Swift hosts need no C shim.

Anything else?
  • Runtime side: NativeScript/ios#488. After it, the NativeScriptSDK SwiftPM product additionally embeds a default-metadata framework for zero-config hosts, while the NativeScript product stays lean.
  • Related docs change outside this repo: NativeScript/ns-embed-example tells hosts to add NativeScriptSDK. Hosts set up with ns embed link their own metadata and should add the NativeScript product instead, otherwise they also carry the unused 8.8 MB default-metadata framework.
Please accept these terms
Vorherrschende Sprache
JavaScript
Sterne
1.1k
Forks
203
Ø Merge
3 T. 4 Std.
Gemergte PRs (30 T.)
8

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus NativeScript/nativescript-cli

Alle Issues in NativeScript/nativescript-cli

Ähnliche Issues

Weitere Issues zu JavaScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.