Fix cleanup request removal presence check logging

Offen

#6,090 erstellt am 25.7.2026 0 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@edusperoni arbeitet bereits daran.

Seit 25.7.2026.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Beschreibung

Summary

removeRequest in lib/detached-processes/cleanup-process.ts uses a self-comparison in its existence check:

The predicate compares currentRequestInfo with itself, so it evaluates to true whenever the request queue is non-empty.
The subsequent _.remove call already correctly compares each queued request against the supplied requestInfo.

As a result, removing a request that was never queued can log that it was removed when there are other queued requests. The request list itself is not incorrectly modified; the impact is limited to the success-versus-absent-request log branch.

Required change

Update the removeRequest existence predicate to compare currentRequestInfo with the incoming requestInfo, matching the predicate used by _.remove.

Affected area

lib/detached-processes/cleanup-process.ts — removeRequest

Acceptance criteria

removeRequest selects the successful-removal branch only when an equal queued request exists.
Removing an absent request logs the existing “cannot remove … has not been added before” message.
Removing an existing request continues to remove it and log the existing successful-removal message.

Context

Reported during PR #6089: https://github.com/NativeScript/nativescript-cli/pull/6089
Original review discussion: https://github.com/NativeScript/nativescript-cli/pull/6089#discussion_r3650504137
Requested by @edusperoni.

Vorherrschende Sprache: JavaScript
Sterne: 1.1k
Forks: 204
Ø Merge: 1 T. 9 Std.
Gemergte PRs (30 T.): 8

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
Forken Sie das Repository und arbeiten Sie in einem Branch.
Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus NativeScript/nativescript-cli

cli does not recognize physical iOS devices (since cli 9.1.0) Offen

in-progress

NativeScript/nativescript-cli#6140 · 2 Kommentare · 1 zugewiesene Person · Erstellt am 31.8.2026
ns 9 running test after running the app starts the app not the test runner. Offen

in progress

NativeScript/nativescript-cli#6015 · 1 Reaktion · 1 zugewiesene Person · Erstellt am 01.5.2026
[note]: SPM preferred over Cocoapods going forward with plugins Offen

question

Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 48/100

NativeScript/nativescript-cli#5992 · 5 Kommentare · Erstellt am 26.3.2026
feat: default output could suppress xcode build logs, enable via flag Offen

feature-pending-triage

Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 35/100

NativeScript/nativescript-cli#5975 · Erstellt am 27.2.2026
ns build android fails in CI environment without emulator Offen

bug-pending-triage

Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 45/100

NativeScript/nativescript-cli#5921 · Erstellt am 25.11.2025

Alle Issues in NativeScript/nativescript-cli