Fix cleanup request removal presence check logging
@edusperoni ya está trabajando en esto.
Desde el 25/7/2026.
Evaluación
Este issue todavía no se ha evaluado.
Descripción
Summary
removeRequest in lib/detached-processes/cleanup-process.ts uses a self-comparison in its existence check:
- The predicate compares
currentRequestInfowith itself, so it evaluates to true whenever the request queue is non-empty. - The subsequent
_.removecall already correctly compares each queued request against the suppliedrequestInfo.
As a result, removing a request that was never queued can log that it was removed when there are other queued requests. The request list itself is not incorrectly modified; the impact is limited to the success-versus-absent-request log branch.
Required change
Update the removeRequest existence predicate to compare currentRequestInfo with the incoming requestInfo, matching the predicate used by _.remove.
Affected area
lib/detached-processes/cleanup-process.ts—removeRequest
Acceptance criteria
removeRequestselects the successful-removal branch only when an equal queued request exists.- Removing an absent request logs the existing “cannot remove … has not been added before” message.
- Removing an existing request continues to remove it and log the existing successful-removal message.
Context
- Reported during PR #6089: https://github.com/NativeScript/nativescript-cli/pull/6089
- Original review discussion: https://github.com/NativeScript/nativescript-cli/pull/6089#discussion_r3650504137
- Requested by @edusperoni.
- Lenguaje dominante
- JavaScript
- Estrellas
- 1.1k
- Forks
- 204
- Merge medio
- 1 d 6 h
- PR fusionados (30 d)
- 9
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de NativeScript/nativescript-cli
-
in-progress
NativeScript/nativescript-cli#6140 · 2 comentarios · 1 asignado ·
-
in progress
NativeScript/nativescript-cli#6015 · 1 reacción · 1 asignado ·
-
question
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
NativeScript/nativescript-cli#5992 · 5 comentarios ·
-
feature-pending-triage
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
NativeScript/nativescript-cli#5975 ·
-
bug-pending-triage
Dificultad 3/5 1-2 días Aptitud para principiantes 45/100
NativeScript/nativescript-cli#5921 ·
Todos los issues de NativeScript/nativescript-cli
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
-
Theme loads third-party resources on every page (jsdelivr web font, cdnjs Font Awesome) – GDPR Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
docToolchain/docToolchain#1705 ·
-
Timezone select lists one option per character; duplicate "Failed" reason; shared tracker popover id Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
nightscout/nocturne#1414 ·
-
bug v2
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
modelcontextprotocol/inspector#2458 · 1 comentario ·
-
Mend: dependency security vulnerability status: needs triage 🕵️♀️
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
carbon-design-system/ibm-products#9907 ·