Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

Security: 3 oras-go CVEs + 1 x/text CVE, all reachable (govulncheck-confirmed) — proposing a dependency bump

Offen
  • Stimmt etwas nicht?
#306 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
72/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
go
Bereich
build-system, ci-cd, security

Rechercherichtung

Start with go.mod and the reachable call sites in pkg/common/artifact/oci_artifact.go, pkg/commands/deploy_actions.go, and pkg/commands/keystore/create_keystore.go. Review the pinned Go versions in checks.yml, build.yml, tests.yml, golangci-lint.yml, create.yml, devnet.yml, e2e.yml, and release.yml, then run govulncheck ./..., go build ./..., go vet ./..., and make tests-fast. Done means the four reachable CVEs no longer appear and the relevant checks pass.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Hi — per the README's note to open an issue before a PR for significant changes, flagging this one first since the fix forces a go directive bump that touches every CI workflow's pinned Go version.

What govulncheck ./... found

go.mod currently pins oras.land/oras-go/v2 v2.3.1 and golang.org/x/text v0.26.0. Running govulncheck ./... against current main shows four reachable vulnerabilities (not just pinned-but-unused — the tool traces the call path back to this repo's own source):

oras-go (3 CVEs, all fixed in v2.6.1):

  • GO-2026-5885 / CVE-2026-48978 — malicious registry can hijack the Bearer-token realm to exfiltrate credentials/refresh tokens
  • GO-2026-5884 — registry credentials forwarded across redirects
  • GO-2026-5882 / CVE-2026-50151 — blob-upload credential forwarding via an unvalidated Location header

All three trace to the same call site:

pkg/common/artifact/oci_artifact.go:237:20: artifact.OCIArtifactBuilder.CreateEigenRuntimeArtifact
    calls oras.Copy, which eventually calls auth.Client.Do / remote.Repository.Push

x/text (1 CVE, fixed in v0.39.0):

  • GO-2026-5970 / CVE-2026-56852 — infinite loop on invalid input
pkg/commands/deploy_actions.go:507:75: commands.DeployL2ContractsAction calls cases.Caser.String, which eventually calls norm.Form.Properties
pkg/commands/keystore/create_keystore.go:86:47: keystore.CreateBLSKeystore calls keystore.SaveToKeystoreWithCurveType, which eventually calls norm.Form.String

The catch worth flagging before a PR

The lowest oras-go version that actually contains the fix is v2.6.1, and upstream bumped its own go directive to go 1.25.0 starting at that release (v2.6.0 is still go 1.23.0 but does not contain the fix). So clearing these CVEs unavoidably means bumping this repo's own go.mod from go 1.23.6 to go 1.25.0 — which is also required by the x/text fix version, so no second bump is needed once both land together.

This repo's CI pins Go 1.23/1.24 explicitly across every workflow (checks.yml, build.yml, tests.yml, golangci-lint.yml: 1.23; create.yml, devnet.yml, e2e.yml, release.yml: 1.24/1.24.2) — none at 1.25 yet. With GOTOOLCHAIN=auto (Go's default since 1.21) go build/go test on those runners should auto-fetch the 1.25 toolchain at CI time, but I wanted to say so explicitly rather than have it be a surprise, since you may prefer to bump actions/setup-go's pinned version in the same PR instead of relying on auto-toolchain-fetch.

What I've already verified in a scratch fork clone (not pushed anywhere yet)

  • go get oras.land/oras-go/[email protected] golang.org/x/[email protected] && go mod tidy — clean, no code changes required.
  • go build ./... and go vet ./... — clean.
  • make tests-fast (your own short-mode target) — all packages pass, including pkg/common/artifact and pkg/commands/keystore which exercise the changed code paths directly.
  • Re-ran govulncheck ./... post-bump — all four CVEs above drop out of the reachable set.

Happy to open the PR now if that sounds right, or adjust scope/approach first if you'd rather handle the go directive bump differently (e.g. bundling an actions/setup-go version bump in the same change).

Vorherrschende Sprache
Go
Sterne
28
Forks
12
Keine gemergten PRs in 30 T.

Entwicklungsumgebung

  • Kein Dockerfile und keine Docker-Compose-Datei
  • Hat eine Pull-Request-Vorlage
  • Kein Beitragsleitfaden

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus Layr-Labs/devkit-cli

Alle Issues in Layr-Labs/devkit-cli

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.