Security: 3 oras-go CVEs + 1 x/text CVE, all reachable (govulncheck-confirmed) — proposing a dependency bump
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 72/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- go
- 领域
- build-system, ci-cd, security
调研方向
Start with go.mod and the reachable call sites in pkg/common/artifact/oci_artifact.go, pkg/commands/deploy_actions.go, and pkg/commands/keystore/create_keystore.go. Review the pinned Go versions in checks.yml, build.yml, tests.yml, golangci-lint.yml, create.yml, devnet.yml, e2e.yml, and release.yml, then run govulncheck ./..., go build ./..., go vet ./..., and make tests-fast. Done means the four reachable CVEs no longer appear and the relevant checks pass.
由索引模型根据 Issue 内容生成。
描述
Hi — per the README's note to open an issue before a PR for significant changes, flagging this one first since the fix forces a go directive bump that touches every CI workflow's pinned Go version.
What govulncheck ./... found
go.mod currently pins oras.land/oras-go/v2 v2.3.1 and golang.org/x/text v0.26.0. Running govulncheck ./... against current main shows four reachable vulnerabilities (not just pinned-but-unused — the tool traces the call path back to this repo's own source):
oras-go (3 CVEs, all fixed in v2.6.1):
- GO-2026-5885 / CVE-2026-48978 — malicious registry can hijack the Bearer-token realm to exfiltrate credentials/refresh tokens
- GO-2026-5884 — registry credentials forwarded across redirects
- GO-2026-5882 / CVE-2026-50151 — blob-upload credential forwarding via an unvalidated
Locationheader
All three trace to the same call site:
pkg/common/artifact/oci_artifact.go:237:20: artifact.OCIArtifactBuilder.CreateEigenRuntimeArtifact
calls oras.Copy, which eventually calls auth.Client.Do / remote.Repository.Push
x/text (1 CVE, fixed in v0.39.0):
- GO-2026-5970 / CVE-2026-56852 — infinite loop on invalid input
pkg/commands/deploy_actions.go:507:75: commands.DeployL2ContractsAction calls cases.Caser.String, which eventually calls norm.Form.Properties
pkg/commands/keystore/create_keystore.go:86:47: keystore.CreateBLSKeystore calls keystore.SaveToKeystoreWithCurveType, which eventually calls norm.Form.String
The catch worth flagging before a PR
The lowest oras-go version that actually contains the fix is v2.6.1, and upstream bumped its own go directive to go 1.25.0 starting at that release (v2.6.0 is still go 1.23.0 but does not contain the fix). So clearing these CVEs unavoidably means bumping this repo's own go.mod from go 1.23.6 to go 1.25.0 — which is also required by the x/text fix version, so no second bump is needed once both land together.
This repo's CI pins Go 1.23/1.24 explicitly across every workflow (checks.yml, build.yml, tests.yml, golangci-lint.yml: 1.23; create.yml, devnet.yml, e2e.yml, release.yml: 1.24/1.24.2) — none at 1.25 yet. With GOTOOLCHAIN=auto (Go's default since 1.21) go build/go test on those runners should auto-fetch the 1.25 toolchain at CI time, but I wanted to say so explicitly rather than have it be a surprise, since you may prefer to bump actions/setup-go's pinned version in the same PR instead of relying on auto-toolchain-fetch.
What I've already verified in a scratch fork clone (not pushed anywhere yet)
go get oras.land/oras-go/[email protected] golang.org/x/[email protected] && go mod tidy— clean, no code changes required.go build ./...andgo vet ./...— clean.make tests-fast(your own short-mode target) — all packages pass, includingpkg/common/artifactandpkg/commands/keystorewhich exercise the changed code paths directly.- Re-ran
govulncheck ./...post-bump — all four CVEs above drop out of the reachable set.
Happy to open the PR now if that sounds right, or adjust scope/approach first if you'd rather handle the go directive bump differently (e.g. bundling an actions/setup-go version bump in the same change).
- 主要语言
- Go
- 星标
- 28
- 派生
- 11
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
Layr-Labs/devkit-cli 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 35/100
Layr-Labs/devkit-cli#300 ·
-
难度 3/5 1-2 天 新手友好度 38/100
Layr-Labs/devkit-cli#237 ·
-
难度 3/5 1-2 天 新手友好度 35/100
Layr-Labs/devkit-cli#231 · 3 条评论 · 1 个 reaction ·
-
难度 3/5 1-2 天 新手友好度 42/100
Layr-Labs/devkit-cli#221 · 2 条评论 ·
-
难度 4/5 3-5 天 新手友好度 35/100
Layr-Labs/devkit-cli#217 ·
查看 Layr-Labs/devkit-cli 的全部 Issue
相似的 Issue
-
Add Solenta可能已有人在做 @sharmao07 今天认领。 未关闭
难度 1/5 1 小时以内 新手友好度 85/100
slavakurilyak/awesome-ai-agents#760 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
-
agent-review-finding bug
难度 2/5 1-3 小时 新手友好度 68/100
jordansmall/spindrift#5281 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 62/100
compiler-explorer/compiler-explorer#9272 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
github/github-mcp-server#3489 ·
维护者通常 4 天内回复