http_static: a file outside the root is opened before it is refused, and 403 against 404 tells whether it exists
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Anfängerfreundlichkeit
- 25/100
Rechercherichtung
Start with open_static_file_confined in src/ext_http.c, then read the status handling and existing cases in tests/test_static_prefixes.py and tests/sections/45f-static-prefixes.sh. First run the stated oracle and FIFO checks under a timeout, then compare Go http.FileServer, nginx, and Python http.server for traversal, escaping symlinks, and missing files. Done means documenting that comparison and adding tests showing lookup is confined before opening and outside paths get the same answer as missing paths.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
What. open_static_file_confined (src/ext_http.c) opens the requested file first and decides afterwards whether it lies under the static root: it builds static_dir + "/" + rel, calls open(filepath, O_RDONLY | O_CLOEXEC), reads the opened file's real path back through /proc/self/fd, and only then compares it with the root. The caller answers 404 when the open fails and 403 when the file opened but lies outside the root. rel reaches it with its .. segments intact (the caller refuses only a second leading slash).
Two consequences, read from the code on phase2-numbers at 6645d9cf; neither has been run yet:
- The two answers tell a client whether a path outside the root exists.
GET <prefix>/../../<anything>is 403 when the target exists and can be opened, and 404 when it does not. The suite pins exactly that pair (tests/test_static_prefixes.py:/../secretis 403,/missingis 404), so the difference is behaviour today, not an accident of one build. - The file outside the root is opened before it is refused, with neither
O_NOFOLLOWnorO_NONBLOCK. Opening a FIFO for reading blocks until a writer comes, so a path that resolves to one (through.., or through a symbolic link inside the root) can hold a worker; opening some device files has effects of its own.
The standard answer (to be filled by running each, not from memory, before the change is built): what Go's http.FileServer, nginx and Python's http.server answer for a .. path that leaves the root, for a symbolic link that leaves it, and for a missing file; and whether each opens anything outside the root on the way. The shape they are expected to share: the path is made safe before any file is opened (a .. cannot leave the root at all), and a client cannot tell "outside" from "missing".
Done when
- Shown by a run on the
serverbuild: a request whose path leaves the root through..gets a different status for an existing target than for a missing one (the oracle), and a request that resolves to a FIFO outside the root holds its worker (under atimeout, so the row cannot hang the suite). - The table of the three servers above, filled by running each, is on this issue, and the decision (which status, for which case) is recorded with it. If the answer for a path outside the root changes from 403,
tests/test_static_prefixes.py's rows change with it and the changelog fragment goes underchanges/breaking/. - Nothing outside the root is opened: the lookup is confined before the
open(the path refused or resolved beneath the root's own descriptor), shown by a row that plants a FIFO outside the root and a symbolic link to it inside, and gets its answer at once. - A client gets the same answer for "outside the root" and for "does not exist", for both the
..case and the link case; the rows that pin it fail on today's code. - The rows run in the hosted lanes that build the server (
tests/sections/45f-static-prefixes.sh), and a plant that puts theopenback before the check turns one of them red.
Found by an automated review of pushed commits on 2026-11-19; the code is unchanged by those commits (it came with #2362 and #2422).
— Claude DevBox
- Vorherrschende Sprache
- C
- Sterne
- 3
- Forks
- 7
- Ø Merge
- 3 Std. 28 Min.
- Gemergte PRs (30 T.)
- 270
Entwicklungsumgebung
Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.
- Enthält ein Dockerfile oder eine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus InauguralSystems/EigenScript
-
area:gates kind:gate-defect
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 83/100
InauguralSystems/EigenScript#2476 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area:gates needs-triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
InauguralSystems/EigenScript#2462 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
The hosted-RNG check refuses a clean tree that has a tracked file with a double quote in its nameOffenarea:gates kind:gate-defect needs-triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
InauguralSystems/EigenScript#2461 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
area:gates kind:gate-defect needs-triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 86/100
InauguralSystems/EigenScript#2458 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
`http_post`: `headers` text with something after its JSON value now means no headers, without a wordOffenarea:http kind:silent-wrong
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
InauguralSystems/EigenScript#2394 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in InauguralSystems/EigenScript
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 92/100
flipperdevices/flipperzero-firmware#4520 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area/build-framework kind/enhancement priority/low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 77/100
yugabyte/yugabyte-db#38826 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100
meshcore-dev/MeshCore#3891 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
Bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
Maintainer antworten meist innerhalb von 1 Tag