http_static: a file outside the root is opened before it is refused, and 403 against 404 tells whether it exists
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 5/5
- Tempo estimado
- Mais de uma semana
- Facilidade para iniciantes
- 25/100
Direção de pesquisa
Start with open_static_file_confined in src/ext_http.c, then read the status handling and existing cases in tests/test_static_prefixes.py and tests/sections/45f-static-prefixes.sh. First run the stated oracle and FIFO checks under a timeout, then compare Go http.FileServer, nginx, and Python http.server for traversal, escaping symlinks, and missing files. Done means documenting that comparison and adding tests showing lookup is confined before opening and outside paths get the same answer as missing paths.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
What. open_static_file_confined (src/ext_http.c) opens the requested file first and decides afterwards whether it lies under the static root: it builds static_dir + "/" + rel, calls open(filepath, O_RDONLY | O_CLOEXEC), reads the opened file's real path back through /proc/self/fd, and only then compares it with the root. The caller answers 404 when the open fails and 403 when the file opened but lies outside the root. rel reaches it with its .. segments intact (the caller refuses only a second leading slash).
Two consequences, read from the code on phase2-numbers at 6645d9cf; neither has been run yet:
- The two answers tell a client whether a path outside the root exists.
GET <prefix>/../../<anything>is 403 when the target exists and can be opened, and 404 when it does not. The suite pins exactly that pair (tests/test_static_prefixes.py:/../secretis 403,/missingis 404), so the difference is behaviour today, not an accident of one build. - The file outside the root is opened before it is refused, with neither
O_NOFOLLOWnorO_NONBLOCK. Opening a FIFO for reading blocks until a writer comes, so a path that resolves to one (through.., or through a symbolic link inside the root) can hold a worker; opening some device files has effects of its own.
The standard answer (to be filled by running each, not from memory, before the change is built): what Go's http.FileServer, nginx and Python's http.server answer for a .. path that leaves the root, for a symbolic link that leaves it, and for a missing file; and whether each opens anything outside the root on the way. The shape they are expected to share: the path is made safe before any file is opened (a .. cannot leave the root at all), and a client cannot tell "outside" from "missing".
Done when
- Shown by a run on the
serverbuild: a request whose path leaves the root through..gets a different status for an existing target than for a missing one (the oracle), and a request that resolves to a FIFO outside the root holds its worker (under atimeout, so the row cannot hang the suite). - The table of the three servers above, filled by running each, is on this issue, and the decision (which status, for which case) is recorded with it. If the answer for a path outside the root changes from 403,
tests/test_static_prefixes.py's rows change with it and the changelog fragment goes underchanges/breaking/. - Nothing outside the root is opened: the lookup is confined before the
open(the path refused or resolved beneath the root's own descriptor), shown by a row that plants a FIFO outside the root and a symbolic link to it inside, and gets its answer at once. - A client gets the same answer for "outside the root" and for "does not exist", for both the
..case and the link case; the rows that pin it fail on today's code. - The rows run in the hosted lanes that build the server (
tests/sections/45f-static-prefixes.sh), and a plant that puts theopenback before the check turns one of them red.
Found by an automated review of pushed commits on 2026-11-19; the code is unchanged by those commits (it came with #2362 and #2422).
— Claude DevBox
- Linguagem predominante
- C
- Estrelas
- 3
- Forks
- 7
- Merge médio
- 3h 28min
- PRs com merge (30d)
- 270
Preparar o ambiente
Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.
- Inclui um Dockerfile ou arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de InauguralSystems/EigenScript
-
area:gates kind:gate-defect
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 83/100
InauguralSystems/EigenScript#2476 ·
Mantenedores costumam responder em até 1 dia
-
area:gates needs-triage
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
InauguralSystems/EigenScript#2462 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
The hosted-RNG check refuses a clean tree that has a tracked file with a double quote in its nameAbertaarea:gates kind:gate-defect needs-triage
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
InauguralSystems/EigenScript#2461 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
area:gates kind:gate-defect needs-triage
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 86/100
InauguralSystems/EigenScript#2458 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
`http_post`: `headers` text with something after its JSON value now means no headers, without a wordAbertaarea:http kind:silent-wrong
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
InauguralSystems/EigenScript#2394 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
Todas as issues de InauguralSystems/EigenScript
Issues semelhantes
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 62/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 92/100
flipperdevices/flipperzero-firmware#4520 ·
Mantenedores costumam responder em até 1 dia
-
area/build-framework kind/enhancement priority/low
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 77/100
yugabyte/yugabyte-db#38826 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 88/100
meshcore-dev/MeshCore#3891 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
Bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 66/100
vlang/v#32675 · 1 comentário ·
Mantenedores costumam responder em até 1 dia