Feat: Type-safety using a FactTypeMapping

Offen
#342 1 Kommentar 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Anfängerfreundlichkeit
25/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Veraltet

Rechercherichtung

Beginne mit den öffentlichen Deklarationen, die durch engineFactory, Engine, Almanac und Fact repräsentiert werden. Vergleiche die vorgeschlagene wörterbuchbasierte Inferenz mit der aktuellen generischen Verwendung; abgeschlossen bedeutet, dass die unterstützte API, das Inferenzverhalten und die Richtlinie für Breaking Changes vereinbart und validiert sind.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

We're doing a quick POC and looking at using this library. One thing that I'd love to see is the ability to enforce or at least make consistent the concept of fact types. Something along the lines of:

type Dictionary = {
  userId: number;
};

const engine = rulesEngine<Dictionary>([]);
engine.addFact("userId", 1);
// Not Valid:
// engine.addFact("userId", false);
expectType<Fact<number, Dictionary>>(engine.getFact("userId"));
expectType<Fact<unknown, Dictionary>>(engine.getFact("other"));

engine.addFact("userId", (params, almanac) => {
  expectType<Almanac<Dictionary>>(almanac);
  expectType<Promise<number>>(almanac.factValue("userId"));
  expectType<Promise<unknown>>(almanac.factValue("other"));
  return 43;
});

You get the idea. Let users specify a dictionary of facts whose type is known ahead of time and fixed. Today, this is kind of done by just letting the user set the type of the fact value, but it doesn't carry through the system.

I took an initial stab at doing this which is below, but the issue is that this would require a breaking type change.

Today since users can specify the type almanac.factValue<number>('userId'). But in order to infer types, we'd need to template the key-type as well, giving us two generics. TS doesn't like having partially filled out generics...so we hit an impasse: if we want to allow user overriding of the types, then we'll need to ask people to specify <number, string> where before it was just <number>.

Of course the ideal scenario is that they remove the template together and just pass a dictionary of types on engine construction; changing this usage would be smoothest by default, but they could still override the type by casting through any (or we could make any the default instead of unknown).

Here's the new ts file, complete with changes if anyone would like to play around further or discuss more.

View Code
export interface EngineOptions {
  allowUndefinedFacts?: boolean;
  allowUndefinedConditions?: boolean;
  pathResolver?: PathResolver;
}

export interface EngineResult<FactTypeDictionary> {
  events: Event[];
  failureEvents: Event[];
  almanac: Almanac<FactTypeDictionary>;
  results: RuleResult[];
  failureResults: RuleResult[];
}

export default function engineFactory<
  FactTypeDictionary extends Record<string, any> = {}
>(
  rules: Array<RuleProperties<FactTypeDictionary>>,
  options?: EngineOptions
): Engine<FactTypeDictionary>;

// This helper gives us optionality. If the key is in the dictionary, then we return the type,
// otherwise we return the default type which is unknown (unless the user specifies it on the call itself)
type FactReturn<
  Dictionary,
  Key,
  Default = unknown
> = Key extends keyof Dictionary ? Dictionary[Key] : Default;

export class Engine<FactTypeDictionary extends Record<string, any> = {}> {
  constructor(
    rules?: Array<RuleProperties<FactTypeDictionary>>,
    options?: EngineOptions
  );

  addRule(rule: RuleProperties<FactTypeDictionary>): this;
  removeRule(ruleOrName: Rule | string): boolean;
  updateRule(rule: Rule): void;

  setCondition(name: string, conditions: TopLevelCondition): this;
  removeCondition(name: string): boolean;

  addOperator(operator: Operator): Map<string, Operator>;
  addOperator<A, B>(
    operatorName: string,
    callback: OperatorEvaluator<A, B>
  ): Map<string, Operator>;
  removeOperator(operator: Operator | string): boolean;

  addFact<T>(fact: Fact<T>): this;
  addFact<DefaultValueType, Key extends string>(
    id: Key,
    valueCallback:
      | DynamicFactCallback<
          FactReturn<FactTypeDictionary, Key, DefaultValueType>,
          FactTypeDictionary
        >
      | FactReturn<FactTypeDictionary, Key, DefaultValueType>,
    options?: FactOptions
  ): this;
  removeFact(factOrId: string | Fact<any>): boolean;
  getFact<Key extends string>(
    factId: Key
  ): Fact<FactReturn<FactTypeDictionary, Key>, FactTypeDictionary>;

  on(eventName: "success", handler: EventHandler<FactTypeDictionary>): this;
  on(eventName: "failure", handler: EventHandler<FactTypeDictionary>): this;
  on(eventName: string, handler: EventHandler<FactTypeDictionary>): this;

  // TODO: This run keyset should optionally reference the types from FactTypeDictionary
  run(facts?: Record<string, any>): Promise<EngineResult<FactTypeDictionary>>;
  stop(): this;
}

export interface OperatorEvaluator<A, B> {
  (factValue: A, compareToValue: B): boolean;
}

export class Operator<A = unknown, B = unknown> {
  public name: string;
  constructor(
    name: string,
    evaluator: OperatorEvaluator<A, B>,
    validator?: (factValue: A) => boolean
  );
}

export class Almanac<FactTypeDictionary> {
  // If a path is passed, then we don't have a good way to know the type anymore so we return unknown
  factValue<Key extends string, Path>(
    factId: Key,
    params?: Record<string, any>,
    path?: Path
  ): Promise<
    Path extends string ? unknown : FactReturn<FactTypeDictionary, Key>
  >;
  addRuntimeFact<Key extends string>(
    factId: Key,
    value: FactReturn<FactTypeDictionary, Key, any>
  ): void;
}

export type FactOptions = {
  cache?: boolean;
  priority?: number;
};

export type DynamicFactCallback<T, FactTypeDictionary> = (
  params: Record<string, any>,
  almanac: Almanac<FactTypeDictionary>
) => T;

export class Fact<T = unknown, FactTypeDictionary = {}> {
  id: string;
  priority: number;
  options: FactOptions;
  value?: T;
  calculationMethod?: DynamicFactCallback<T, FactTypeDictionary>;

  constructor(
    id: string,
    value: T | DynamicFactCallback<T, FactTypeDictionary>,
    options?: FactOptions
  );
}

export interface Event {
  type: string;
  params?: Record<string, any>;
}

export type PathResolver = (value: object, path: string) => any;

export type EventHandler<FactTypeDictionary> = (
  event: Event,
  almanac: Almanac<FactTypeDictionary>,
  ruleResult: RuleResult
) => void;

export interface RuleProperties<FactTypeDictionary = {}> {
  conditions: TopLevelCondition;
  event: Event;
  name?: string;
  priority?: number;
  onSuccess?: EventHandler<FactTypeDictionary>;
  onFailure?: EventHandler<FactTypeDictionary>;
}
export type RuleSerializable = Pick<
  Required<RuleProperties<any>>,
  "conditions" | "event" | "name" | "priority"
>;

export interface RuleResult {
  name: string;
  conditions: TopLevelCondition;
  event?: Event;
  priority?: number;
  result: any;
}

// Something like a rule could be constructed outside of the context of an engine.
// For simplicity, we just default it to an empty dictionary since often the types won't come up in the rule definition
// (basically only if you were to attach an event, AND reference factValue from the almanac)
export class Rule<FactTypeDictionary extends Record<string, any> = {}>
  implements RuleProperties<FactTypeDictionary>
{
  constructor(ruleProps: RuleProperties<FactTypeDictionary> | string);
  name: string;
  conditions: TopLevelCondition;
  event: Event;
  priority: number;
  setConditions(conditions: TopLevelCondition): this;
  setEvent(event: Event): this;
  setPriority(priority: number): this;
  toJSON(): string;
  toJSON<T extends boolean>(
    stringify: T
  ): T extends true ? string : RuleSerializable;
}

interface ConditionProperties {
  fact: string;
  operator: string;
  value: { fact: string } | any;
  path?: string;
  priority?: number;
  params?: Record<string, any>;
  name?: string;
}

type NestedCondition = ConditionProperties | TopLevelCondition;
type AllConditions = {
  all: NestedCondition[];
  name?: string;
  priority?: number;
};
type AnyConditions = {
  any: NestedCondition[];
  name?: string;
  priority?: number;
};
type NotConditions = { not: NestedCondition; name?: string; priority?: number };
type ConditionReference = {
  condition: string;
  name?: string;
  priority?: number;
};
export type TopLevelCondition =
  | AllConditions
  | AnyConditions
  | NotConditions
  | ConditionReference;

Vorherrschende Sprache
JavaScript
Sterne
3.1k
Forks
507
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus CacheControl/json-rules-engine

Alle Issues in CacheControl/json-rules-engine

Ähnliche Issues

Weitere Issues zu JavaScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.