Feat: Type-safety using a FactTypeMapping
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 25/100
- issue の種類
- 機能追加
- 明瞭さ
- おおむね明確
- 活発さ
- 停滞
- 技術スタック
- javascript, typescript
調査の方向性
engineFactory、Engine、Almanac、Fact で表される公開宣言から始めます。提案されている辞書ベースの推論を現在の汎用的な使用方法と比較します。完了とは、サポート対象の API、推論の動作、breaking change ポリシーについて合意し、検証されている状態を意味します。
索引モデルが issue の本文から書いたものです。
説明
We're doing a quick POC and looking at using this library. One thing that I'd love to see is the ability to enforce or at least make consistent the concept of fact types. Something along the lines of:
type Dictionary = {
userId: number;
};
const engine = rulesEngine<Dictionary>([]);
engine.addFact("userId", 1);
// Not Valid:
// engine.addFact("userId", false);
expectType<Fact<number, Dictionary>>(engine.getFact("userId"));
expectType<Fact<unknown, Dictionary>>(engine.getFact("other"));
engine.addFact("userId", (params, almanac) => {
expectType<Almanac<Dictionary>>(almanac);
expectType<Promise<number>>(almanac.factValue("userId"));
expectType<Promise<unknown>>(almanac.factValue("other"));
return 43;
});
You get the idea. Let users specify a dictionary of facts whose type is known ahead of time and fixed. Today, this is kind of done by just letting the user set the type of the fact value, but it doesn't carry through the system.
I took an initial stab at doing this which is below, but the issue is that this would require a breaking type change.
Today since users can specify the type almanac.factValue<number>('userId'). But in order to infer types, we'd need to template the key-type as well, giving us two generics. TS doesn't like having partially filled out generics...so we hit an impasse: if we want to allow user overriding of the types, then we'll need to ask people to specify <number, string> where before it was just <number>.
Of course the ideal scenario is that they remove the template together and just pass a dictionary of types on engine construction; changing this usage would be smoothest by default, but they could still override the type by casting through any (or we could make any the default instead of unknown).
Here's the new ts file, complete with changes if anyone would like to play around further or discuss more.
View Code
export interface EngineOptions {
allowUndefinedFacts?: boolean;
allowUndefinedConditions?: boolean;
pathResolver?: PathResolver;
}
export interface EngineResult<FactTypeDictionary> {
events: Event[];
failureEvents: Event[];
almanac: Almanac<FactTypeDictionary>;
results: RuleResult[];
failureResults: RuleResult[];
}
export default function engineFactory<
FactTypeDictionary extends Record<string, any> = {}
>(
rules: Array<RuleProperties<FactTypeDictionary>>,
options?: EngineOptions
): Engine<FactTypeDictionary>;
// This helper gives us optionality. If the key is in the dictionary, then we return the type,
// otherwise we return the default type which is unknown (unless the user specifies it on the call itself)
type FactReturn<
Dictionary,
Key,
Default = unknown
> = Key extends keyof Dictionary ? Dictionary[Key] : Default;
export class Engine<FactTypeDictionary extends Record<string, any> = {}> {
constructor(
rules?: Array<RuleProperties<FactTypeDictionary>>,
options?: EngineOptions
);
addRule(rule: RuleProperties<FactTypeDictionary>): this;
removeRule(ruleOrName: Rule | string): boolean;
updateRule(rule: Rule): void;
setCondition(name: string, conditions: TopLevelCondition): this;
removeCondition(name: string): boolean;
addOperator(operator: Operator): Map<string, Operator>;
addOperator<A, B>(
operatorName: string,
callback: OperatorEvaluator<A, B>
): Map<string, Operator>;
removeOperator(operator: Operator | string): boolean;
addFact<T>(fact: Fact<T>): this;
addFact<DefaultValueType, Key extends string>(
id: Key,
valueCallback:
| DynamicFactCallback<
FactReturn<FactTypeDictionary, Key, DefaultValueType>,
FactTypeDictionary
>
| FactReturn<FactTypeDictionary, Key, DefaultValueType>,
options?: FactOptions
): this;
removeFact(factOrId: string | Fact<any>): boolean;
getFact<Key extends string>(
factId: Key
): Fact<FactReturn<FactTypeDictionary, Key>, FactTypeDictionary>;
on(eventName: "success", handler: EventHandler<FactTypeDictionary>): this;
on(eventName: "failure", handler: EventHandler<FactTypeDictionary>): this;
on(eventName: string, handler: EventHandler<FactTypeDictionary>): this;
// TODO: This run keyset should optionally reference the types from FactTypeDictionary
run(facts?: Record<string, any>): Promise<EngineResult<FactTypeDictionary>>;
stop(): this;
}
export interface OperatorEvaluator<A, B> {
(factValue: A, compareToValue: B): boolean;
}
export class Operator<A = unknown, B = unknown> {
public name: string;
constructor(
name: string,
evaluator: OperatorEvaluator<A, B>,
validator?: (factValue: A) => boolean
);
}
export class Almanac<FactTypeDictionary> {
// If a path is passed, then we don't have a good way to know the type anymore so we return unknown
factValue<Key extends string, Path>(
factId: Key,
params?: Record<string, any>,
path?: Path
): Promise<
Path extends string ? unknown : FactReturn<FactTypeDictionary, Key>
>;
addRuntimeFact<Key extends string>(
factId: Key,
value: FactReturn<FactTypeDictionary, Key, any>
): void;
}
export type FactOptions = {
cache?: boolean;
priority?: number;
};
export type DynamicFactCallback<T, FactTypeDictionary> = (
params: Record<string, any>,
almanac: Almanac<FactTypeDictionary>
) => T;
export class Fact<T = unknown, FactTypeDictionary = {}> {
id: string;
priority: number;
options: FactOptions;
value?: T;
calculationMethod?: DynamicFactCallback<T, FactTypeDictionary>;
constructor(
id: string,
value: T | DynamicFactCallback<T, FactTypeDictionary>,
options?: FactOptions
);
}
export interface Event {
type: string;
params?: Record<string, any>;
}
export type PathResolver = (value: object, path: string) => any;
export type EventHandler<FactTypeDictionary> = (
event: Event,
almanac: Almanac<FactTypeDictionary>,
ruleResult: RuleResult
) => void;
export interface RuleProperties<FactTypeDictionary = {}> {
conditions: TopLevelCondition;
event: Event;
name?: string;
priority?: number;
onSuccess?: EventHandler<FactTypeDictionary>;
onFailure?: EventHandler<FactTypeDictionary>;
}
export type RuleSerializable = Pick<
Required<RuleProperties<any>>,
"conditions" | "event" | "name" | "priority"
>;
export interface RuleResult {
name: string;
conditions: TopLevelCondition;
event?: Event;
priority?: number;
result: any;
}
// Something like a rule could be constructed outside of the context of an engine.
// For simplicity, we just default it to an empty dictionary since often the types won't come up in the rule definition
// (basically only if you were to attach an event, AND reference factValue from the almanac)
export class Rule<FactTypeDictionary extends Record<string, any> = {}>
implements RuleProperties<FactTypeDictionary>
{
constructor(ruleProps: RuleProperties<FactTypeDictionary> | string);
name: string;
conditions: TopLevelCondition;
event: Event;
priority: number;
setConditions(conditions: TopLevelCondition): this;
setEvent(event: Event): this;
setPriority(priority: number): this;
toJSON(): string;
toJSON<T extends boolean>(
stringify: T
): T extends true ? string : RuleSerializable;
}
interface ConditionProperties {
fact: string;
operator: string;
value: { fact: string } | any;
path?: string;
priority?: number;
params?: Record<string, any>;
name?: string;
}
type NestedCondition = ConditionProperties | TopLevelCondition;
type AllConditions = {
all: NestedCondition[];
name?: string;
priority?: number;
};
type AnyConditions = {
any: NestedCondition[];
name?: string;
priority?: number;
};
type NotConditions = { not: NestedCondition; name?: string; priority?: number };
type ConditionReference = {
condition: string;
name?: string;
priority?: number;
};
export type TopLevelCondition =
| AllConditions
| AnyConditions
| NotConditions
| ConditionReference;
- 主要言語
- JavaScript
- スター
- 3.1k
- フォーク
- 507
- PR マージ指標
- 30日以内にマージされた PR はありません
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
CacheControl/json-rules-engine のほかの issue
-
難易度 4/5 3〜5日 初心者へのやさしさ 35/100
CacheControl/json-rules-engine#427 · リアクション 1 件 ·
-
難易度 4/5 3〜5日 初心者へのやさしさ 35/100
-
難易度 3/5 1〜2日 初心者へのやさしさ 48/100
CacheControl/json-rules-engine#424 · コメント 1 件 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 25/100
CacheControl/json-rules-engine#421 · コメント 1 件 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 38/100
CacheControl/json-rules-engine#417 · リアクション 1 件 ·
CacheControl/json-rules-engine の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
palladius/rails8-app-on-gcp#145 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
dotenvx/dotenv-vscode#139 ·
-
test-change-proposal
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
web-platform-tests/interop#1455 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
corsairdev/corsair#1764 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100