Failed large file upload leaves the file unfinished and the error has no file id

Offen
  • Stimmt etwas nicht?
#238 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 3 Tagen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
45/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
java
Bereich
backend

Rechercherichtung

Start in core/src/main/java/com/backblaze/b2/client/B2LargeFileUploader.java: read uploadLargeFile (around lines 73-80) and the catch and finally blocks in uploadPartsAndFinish (around lines 241-252), which cancel part futures but never the large file. Before changing anything, decide whether leaving the file for resume is intended, since the issue asks for that decision. Done means the failure path either cancels the large file or includes its file id in the thrown error and javadoc, with a test that fails one part and checks unfinishedLargeFiles.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

What happens

After uploadLargeFile() has started the large file, any failure (a failed part, an interrupt, a rejected task) is rethrown without calling cancelLargeFile. The unfinished large file stays on the server, and the exception does not mention its file id, so the caller cannot easily clean it up or resume it.

Where

core/src/main/java/com/backblaze/b2/client/B2LargeFileUploader.java:73-80 (start the large file) and :241-252 (the catch and finally blocks, which cancel the part futures but never the large file). Public methods B2StorageClient.unfinishedLargeFiles and cancelLargeFile exist.

Why it matters

Impact: Left behind (an unfinished large file stays on the account), loud. Severity: Medium, because it is only reached after a failure partway through an upload, and the caller can find and cancel the file through unfinishedLargeFiles and cancelLargeFile.

How to check

Found by reading the code, not reproduced. Read uploadLargeFile and uploadPartsAndFinish: there is no call to cancel the large file on any failure path. Failing one part in a test and then listing unfinished large files should show the leftover file. If leaving the file is intended so that finishUploadingLargeFile can resume it, the javadoc could say so and include the file id in the error.

Version

Seen at v6.5.0. Present on the default branch: present.

Vorherrschende Sprache
Java
Sterne
103
Forks
23
Ø Merge
5 T. 8 Std.
Gemergte PRs (30 T.)
3

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus Backblaze/b2-sdk-java

Alle Issues in Backblaze/b2-sdk-java

Ähnliche Issues

Weitere Issues zu Java

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.