Failed large file upload leaves the file unfinished and the error has no file id

未关闭
#238 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 3 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
java
领域
backend

调研方向

Start in core/src/main/java/com/backblaze/b2/client/B2LargeFileUploader.java: read uploadLargeFile (around lines 73-80) and the catch and finally blocks in uploadPartsAndFinish (around lines 241-252), which cancel part futures but never the large file. Before changing anything, decide whether leaving the file for resume is intended, since the issue asks for that decision. Done means the failure path either cancels the large file or includes its file id in the thrown error and javadoc, with a test that fails one part and checks unfinishedLargeFiles.

由索引模型根据 Issue 内容生成。

描述

What happens

After uploadLargeFile() has started the large file, any failure (a failed part, an interrupt, a rejected task) is rethrown without calling cancelLargeFile. The unfinished large file stays on the server, and the exception does not mention its file id, so the caller cannot easily clean it up or resume it.

Where

core/src/main/java/com/backblaze/b2/client/B2LargeFileUploader.java:73-80 (start the large file) and :241-252 (the catch and finally blocks, which cancel the part futures but never the large file). Public methods B2StorageClient.unfinishedLargeFiles and cancelLargeFile exist.

Why it matters

Impact: Left behind (an unfinished large file stays on the account), loud. Severity: Medium, because it is only reached after a failure partway through an upload, and the caller can find and cancel the file through unfinishedLargeFiles and cancelLargeFile.

How to check

Found by reading the code, not reproduced. Read uploadLargeFile and uploadPartsAndFinish: there is no call to cancel the large file on any failure path. Failing one part in a test and then listing unfinished large files should show the leftover file. If leaving the file is intended so that finishUploadingLargeFile can resume it, the javadoc could say so and include the file id in the error.

Version

Seen at v6.5.0. Present on the default branch: present.

主要语言
Java
星标
103
派生
23
平均合并
5 天 8 小时
30 天内合并 PR
3

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Backblaze/b2-sdk-java 的其他 Issue

查看 Backblaze/b2-sdk-java 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。