[BUG]: GitHub Personal Access Token (PAT) is stored in plaintext in localStorage

Offen
#421 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@Sandeepkg123 arbeitet bereits daran.

Seit 03.11.2026.

  • #442 von @Sandeepkg123 — offen
  • #445 von @Basharkhan7776 — offen

Bewertung

Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Anfängerfreundlichkeit
35/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
github, javascript

Rechercherichtung

Start by reading the token save and load paths in src/context/AppContext.jsx, the GitHub request in src/services/github.js, and the Settings disclosure in src/pages/SettingsPage.jsx. Determine what protection is feasible for a static browser app and how it affects token use. Done means the token exposure and the mismatch in the Settings explanation are addressed; the issue does not specify a proposed design or tests.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug
Bug Description

The app stores the user's GitHub Personal Access Token (PAT) in plaintext in the browser's localStorage under the key oe_pat. It is not encrypted and not hashed (no bcrypt, no WebCrypto, no AES). Anyone with access to the browser profile, DevTools, or an XSS vulnerability can read the full token and use it to access the user's GitHub account with the token's scopes.

Relevant code:

  • Save (plaintext write): src/context/AppContext.jsx:144 → localStorage.setItem('oe_pat', token)
  • Load (plaintext read): src/context/AppContext.jsx:29 → localStorage.getItem('oe_pat')
  • Delete: src/context/AppContext.jsx:156
  • Token is also sent as-is to GitHub: src/services/github.js:85 → headers.Authorization = \token ${pat}``

The Settings page tells users "Your Personal Access Token (PAT) is stored locally on your device and is never sent to any server" (src/pages/SettingsPage.jsx:143), but does not disclose that it is stored unencrypted and readable by any script on the origin.

Steps to Reproduce
  1. Open the app and go to Settings.
  2. Paste a valid GitHub Personal Access Token and click Save (token is validated against https://api.github.com/rate_limit).
  3. Open DevTools (F12 / Ctrl+Shift+I / Cmd+Option+I) → Application tab → Storage → Local Storage → select the app origin.
  4. Observe the key oe_pat.
  5. Copy the value — it is the full, readable PAT.
  6. Alternatively, in DevTools → Console, run:
    localStorage.getItem('oe_pat')
    The raw token is returned in plaintext.
    
    
Logs and Screenshots

The token can be seen in the browser inspection menu:
Image

Console proof:
Image

Environment Details
  • Browser: Brave Browser (latest stable)
  • OS: Linux
  • App version: v1.0.0
  • Build: Production static build (GitHub Pages)
  • Storage: Browser localStorage
Impact

Critical - Application is unusable

Code of Conduct
  • I have joined the Discord server and will post updates there
  • I have searched existing issues to avoid duplicates
Vorherrschende Sprache
JavaScript
Sterne
53
Forks
182
Ø Merge
18 Min.
Gemergte PRs (30 T.)
2

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus AOSSIE-Org/OrgExplorer

Alle Issues in AOSSIE-Org/OrgExplorer

Ähnliche Issues

Weitere Issues zu JavaScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.