[BUG]: GitHub Personal Access Token (PAT) is stored in plaintext in localStorage

Aperta
#421 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@Sandeepkg123 ci sta già lavorando.

Dal 3/11/2026.

  • #442 di @Sandeepkg123 — aperta
  • #445 di @Basharkhan7776 — aperta

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
github, javascript

Direzione di ricerca

Start by reading the token save and load paths in src/context/AppContext.jsx, the GitHub request in src/services/github.js, and the Settings disclosure in src/pages/SettingsPage.jsx. Determine what protection is feasible for a static browser app and how it affects token use. Done means the token exposure and the mismatch in the Settings explanation are addressed; the issue does not specify a proposed design or tests.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug
Bug Description

The app stores the user's GitHub Personal Access Token (PAT) in plaintext in the browser's localStorage under the key oe_pat. It is not encrypted and not hashed (no bcrypt, no WebCrypto, no AES). Anyone with access to the browser profile, DevTools, or an XSS vulnerability can read the full token and use it to access the user's GitHub account with the token's scopes.

Relevant code:

  • Save (plaintext write): src/context/AppContext.jsx:144 → localStorage.setItem('oe_pat', token)
  • Load (plaintext read): src/context/AppContext.jsx:29 → localStorage.getItem('oe_pat')
  • Delete: src/context/AppContext.jsx:156
  • Token is also sent as-is to GitHub: src/services/github.js:85 → headers.Authorization = \token ${pat}``

The Settings page tells users "Your Personal Access Token (PAT) is stored locally on your device and is never sent to any server" (src/pages/SettingsPage.jsx:143), but does not disclose that it is stored unencrypted and readable by any script on the origin.

Steps to Reproduce
  1. Open the app and go to Settings.
  2. Paste a valid GitHub Personal Access Token and click Save (token is validated against https://api.github.com/rate_limit).
  3. Open DevTools (F12 / Ctrl+Shift+I / Cmd+Option+I) → Application tab → Storage → Local Storage → select the app origin.
  4. Observe the key oe_pat.
  5. Copy the value — it is the full, readable PAT.
  6. Alternatively, in DevTools → Console, run:
    localStorage.getItem('oe_pat')
    The raw token is returned in plaintext.
    
    
Logs and Screenshots

The token can be seen in the browser inspection menu:
Image

Console proof:
Image

Environment Details
  • Browser: Brave Browser (latest stable)
  • OS: Linux
  • App version: v1.0.0
  • Build: Production static build (GitHub Pages)
  • Storage: Browser localStorage
Impact

Critical - Application is unusable

Code of Conduct
  • I have joined the Discord server and will post updates there
  • I have searched existing issues to avoid duplicates
Lingua principale
JavaScript
Stelle
53
Fork
182
Merge medio
18m
PR unite (30g)
2

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di AOSSIE-Org/OrgExplorer

Tutte le issue di AOSSIE-Org/OrgExplorer

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.