enhance_with_llm rewrites created files outside the remediation executor and manifest
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 49/100
Research direction
Start by tracing remediate_audit_findings and the enhancement path in the Baseline orchestrator, then read the remediation executor and manifest handling on the 043 branch. Check how FileChange preview/apply behavior and the FR-011 user-changes check are implemented. Done when enhancement is represented as a planned change, appears in the preview or is marked as not exactly previewable, and is recorded and checked by the manifest flow.
Written by the indexing model from the issue text.
Description
With enhance_with_llm=True, remediate_audit_findings rewrites created documents (ARCHITECTURE.md, the threat model) after the deterministic remediation. The rewrite happens directly in the Baseline orchestrator, outside the remediation executor.
On the 043 branch the executor is the only writer and records every write in the run manifest. The enhanced file therefore no longer matches the manifest digest, and commit_remediation_changes reports a conflict and commits nothing for it. That is safe, but the feature does not work.
Fix: make the enhancement a planned FileChange that goes through the executor:
- the preview shows the enhanced content, or labels it "cannot be previewed exactly" if it is generated at apply time;
- the manifest records it;
- FR-011, the user-changes check, applies to it.
Found while implementing feature 043 (remediation safety, branch 043-remediation-safety, not yet merged).
- Dominant language
- Python
- Stars
- 22
- Forks
- 27
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 48
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from darnitdevorg/darnit
-
ci needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
darnitdevorg/darnit#607 ·
Maintainers usually reply within 2 days
-
dependencies module-baseline needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
darnitdevorg/darnit#606 ·
Maintainers usually reply within 2 days
-
A test starts real Sigstore signing (interactive OIDC login) when the attestation extra is installedPossibly taken A pull request linked to this issue is open or already merged. Openmodule-baseline needs triage testing
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
darnitdevorg/darnit#604 ·
Maintainers usually reply within 2 days
-
`darnit validate` crashes on openssf-baseline.toml summarising levelsPossibly taken @i-am-paradox claimed this 4 days ago. Openinterface-cli module-core
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
darnitdevorg/darnit#589 · 1 comment ·
Maintainers usually reply within 2 days
-
good first issue maintenance
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
darnitdevorg/darnit#587 · 2 comments ·
Maintainers usually reply within 2 days
All issues in darnitdevorg/darnit
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 68/100
FavioVazquez/showtime#101 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
rossant/awesome-math#199 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
nautechsystems/nautilus_trader#5365 ·
Maintainers usually reply within 1 day
-
Examples say cnxOpendocumentation embedded
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day