enhance_with_llm rewrites created files outside the remediation executor and manifest
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start by tracing remediate_audit_findings and the enhancement path in the Baseline orchestrator, then read the remediation executor and manifest handling on the 043 branch. Check how FileChange preview/apply behavior and the FR-011 user-changes check are implemented. Done when enhancement is represented as a planned change, appears in the preview or is marked as not exactly previewable, and is recorded and checked by the manifest flow.
由索引模型根据 Issue 内容生成。
描述
With enhance_with_llm=True, remediate_audit_findings rewrites created documents (ARCHITECTURE.md, the threat model) after the deterministic remediation. The rewrite happens directly in the Baseline orchestrator, outside the remediation executor.
On the 043 branch the executor is the only writer and records every write in the run manifest. The enhanced file therefore no longer matches the manifest digest, and commit_remediation_changes reports a conflict and commits nothing for it. That is safe, but the feature does not work.
Fix: make the enhancement a planned FileChange that goes through the executor:
- the preview shows the enhanced content, or labels it "cannot be previewed exactly" if it is generated at apply time;
- the manifest records it;
- FR-011, the user-changes check, applies to it.
Found while implementing feature 043 (remediation safety, branch 043-remediation-safety, not yet merged).
- 主要语言
- Python
- 星标
- 22
- 派生
- 27
- 平均合并
- 2 天 15 小时
- 30 天内合并 PR
- 52
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
darnitdevorg/darnit 的其他 Issue
-
module-core needs triage ux
难度 2/5 1-3 小时 新手友好度 72/100
darnitdevorg/darnit#648 ·
维护者通常 2 天内回复
-
ci needs triage
难度 2/5 1-3 小时 新手友好度 62/100
darnitdevorg/darnit#607 ·
维护者通常 2 天内回复
-
dependencies module-baseline needs triage
难度 2/5 1-3 小时 新手友好度 68/100
darnitdevorg/darnit#606 ·
维护者通常 2 天内回复
-
`darnit validate` crashes on openssf-baseline.toml summarising levels可能已有人在做 @i-am-paradox 于 11 天前认领。 未关闭interface-cli module-core
难度 2/5 1-3 小时 新手友好度 78/100
darnitdevorg/darnit#589 · 1 条评论 ·
维护者通常 2 天内回复
-
good first issue maintenance
难度 2/5 1-3 小时 新手友好度 83/100
darnitdevorg/darnit#587 · 2 条评论 ·
维护者通常 2 天内回复
查看 darnitdevorg/darnit 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
google-agentic-commerce/AP2#388 ·
-
area:codegen backend:cuda backend:hip bug direction:input
难度 2/5 1-3 小时 新手友好度 78/100
CrossGL/crosstl#3061 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 85/100
rlaope/oh-my-hermes#2304 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 85/100
mochan-tk/agentic-dev-kit-for-codex#64 ·
维护者通常 1 天内回复
-
bug docs performance
难度 1/5 1 小时以内 新手友好度 85/100
维护者通常 3 天内回复