Add NPC dialogue tests to cover givesItem and condition matching

Open
#14 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
game-dev, testing-qa

Research direction

Start by locating NarratorServiceTests and the NpcItemGiven tracking used by the dialogue engine. Exercise the three listed cases, including multiple conditions and no matching dialogue, then compare the observed behavior with decisions B6 and WC3. Done means the tests cover those cases and document the expected engine behavior.

Written by the indexing model from the issue text.

Description

squad:barton testing

NarratorServiceTests exist but need expanded coverage for: NPC givesItem only given once (NpcItemGiven tracking), dialogue condition matching with multiple conditions, edge case where NPC has no matching dialogue. Verify engine behavior matches decision B6 and WC3.

Dominant language
C#
Stars
1
Forks
0
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from csharpfritz/MyFirstTextGame

All issues in csharpfritz/MyFirstTextGame

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.