Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

fix(ui): Escape that closes a menu also cancels an in-flight Move

Open
  • Is something wrong?
#95 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
62/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
desktop

Research direction

The Escape cancel is gated only on !files.is_modal() in src/app/panels.rs (around lines 31-33), so start with cancel_on_escape there and find how shortcuts check for an open popup (Popup::is_any_open). Add the same popup check to the shared native path. Done means Escape with the File menu open closes only the menu while Move stays active and the status is unchanged, a second Escape still cancels, and the Status Line T1 pinned test is updated. The regression test should use real key events.

Written by the indexing model from the issue text.

Description

area/ui-parity good first issue type/bug

Problem

Pressing Escape while any menu or popup is open (for example the File menu) also runs the editor's Escape handling (cancel_on_escape): it cancels an in-flight Move and rewrites the status to "Edit cancelled". The user only meant to close the menu.

Current behavior

src/app/panels.rs (around lines 31-33) gates the Escape cancel only on !files.is_modal(), not on whether an egui popup/menu is open (Popup::is_any_open). Same on main. Found while testing the Status Line menu-set combo; the Status Line T1 test pins the current behavior so a fix flips it deliberately.

Expected

Escape with a menu or popup open closes the popup only; Move and drafts are untouched and the status is unchanged. Escape with no popup open keeps the current cancel behavior.

Acceptance

  • Gate the Escape cancel on no open popup/menu (same predicate shortcuts use), in the shared native path.
  • Regression test with real key events: Move in flight, open File menu, Escape -> menu closes, Move still active, status unchanged; second Escape cancels as today. Update the Status Line T1 pinned test intentionally.
  • Guard ledger note if Escape handling is documented there.
Dominant language
Rust
Stars
4
Forks
2
Avg merge
2h 28m
Merged PRs (30d)
76

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from cristim/AztecCraft

All issues in cristim/AztecCraft

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.