CoderWorkspacePoolMember checkCreate: trust only Coder's own 404 on the name lookup (before PR 12)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
Start in checkCreate in internal/controller/coderworkspacepoolmember_controller.go, where the kwp- name lookup calls isCoderNotFound. Compare it with the fix from #352 in the CoderTemplateTest controller, which uses isCoderResourceNotFound. Add controller tests for an HTML 404 and a Route not found. 404, and check that the create is not sent in either case.
Written by the indexing model from the issue text.
Description
Summary
checkCreate in internal/controller/coderworkspacepoolmember_controller.go looks up the kwp- workspace name before the create with the plain isCoderNotFound. A 404 that Coder did not send (a proxy page, Route not found.) counts as a free name, and the member sends the create. #352 fixed the same lookup in the live CoderTemplateTest controller.
The pool member controller is dormant. Fix this before PR 12 of #153 registers it: use isCoderResourceNotFound and add tests for an HTML 404 and Route not found..
Refs #153
Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: medium
- Dominant language
- Go
- Stars
- 5
- Forks
- 3
- Avg merge
- 2h 56m
- Merged PRs (30d)
- 163
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from coder/coder-k8s
-
🤖 verification skills: harden check.sh and verify.sh argument and file handling (#391 follow-ups)Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
TestReconcile_LicenseRotationUploadsNewSecretValue fails at -count=3 (reuses a control plane name)Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
CoderMCPServer Kind E2E follow-upsPossibly taken @ThomasK33 claimed this 15 days ago. Open
coder/coder-k8s#390 · 1 assignee ·
Maintainers usually reply within 1 day
-
CoderMCPServer delete and RBAC test follow-upsPossibly taken @ThomasK33 claimed this 15 days ago. Open
coder/coder-k8s#378 · 1 assignee ·
Maintainers usually reply within 1 day
-
Ownership proof for Coder IDs recorded in controller status (D11 B)Possibly taken @ThomasK33 claimed this 15 days ago. Open
coder/coder-k8s#372 · 1 assignee ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
orchestration.migration.data.tasks.retry values are ignored by the 8.8 data migration jobPossibly taken @irisfield claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
camunda/camunda-platform-helm#7773 ·
Maintainers usually reply within 1 day
-
Add missing unit tests for IsAdmissionPolicyName and IsCertManagerResourceNamePossibly taken @a1h8 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
kubernetes-sigs/security-profiles-operator#3644 ·
Maintainers usually reply within 1 day
-
[Bug]: Anthropic Responses converter forwards empty text blocks, upstream rejects with 400Possibly taken @david-choi-querypie claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
[DOCS]: enforce_admins description understates what it covers and omits push restrictionsPossibly taken @dav-tb claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 78/100
integrations/terraform-provider-github#3707 · 1 comment ·
Maintainers usually reply within 1 day